Skip to content

Import cookie-store tests from upstream WPT #15282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2023
Merged

Import cookie-store tests from upstream WPT #15282

merged 1 commit into from
Jun 26, 2023

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 25, 2023 •
edited by webkit-early-warning-system
Loading

5ca9730

Import cookie-store tests from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=258503

Reviewed by Tim Nguyen.

Import cookie-store tests from upstream WPT@c76c43b187881421d.

* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/web-platform-tests/cookie-store/*: Added.

Canonical link: https://commits.webkit.org/265517@main

30d375e

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jun 25, 2023
@cdumez cdumez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 78f5228)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez force-pushed the 258503_cookie_store_wpt branch from 78f5228 to cf950e3 Compare June 25, 2023 23:46
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2023 •
edited
Loading

EWS run on previous version of this PR (hash cf950e3)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 26, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Jun 26, 2023
@cdumez cdumez force-pushed the 258503_cookie_store_wpt branch from cf950e3 to 237acd1 Compare June 26, 2023 01:36
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 237acd1)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
⏳ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress
✅ 🛠 watch
⏳ 🛠 watch-sim

@cdumez cdumez force-pushed the 258503_cookie_store_wpt branch from 237acd1 to 30d375e Compare June 26, 2023 01:43
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2023 •
edited
Loading

EWS run on current version of this PR (hash 30d375e)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 26, 2023
@cdumez cdumez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Jun 26, 2023
@cdumez cdumez marked this pull request as ready for review June 26, 2023 15:31
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2023
@cdumez
Import cookie-store tests from upstream WPT
5ca9730 
https://bugs.webkit.org/show_bug.cgi?id=258503

Reviewed by Tim Nguyen.

Import cookie-store tests from upstream WPT@c76c43b187881421d.

* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/web-platform-tests/cookie-store/*: Added.

Canonical link: https://commits.webkit.org/265517@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jun 26, 2023

Committed 265517@main (5ca9730): https://commits.webkit.org/265517@main

Reviewed commits have been landed. Closing PR #15282 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5ca9730 into WebKit:main Jun 26, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@cdumez cdumez

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @nt1m @webkit-ews-buildbot