-
Notifications
You must be signed in to change notification settings - Fork 1.7k
CSS Custom Highlights text decoration does not respect priority #15919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash e52fbf4)
|
rr-codes
reviewed
Jul 19, 2023
rr-codes
reviewed
Jul 19, 2023
Can we add a test? |
EWS run on current version of this PR (hash 2bee93c) |
whsieh
approved these changes
Jul 20, 2023
megangardner
approved these changes
Jul 20, 2023
https://bugs.webkit.org/show_bug.cgi?id=259321 rdar://112494779 Reviewed by Wenson Hsieh. Before if StyledMarkedText was of higher priority, just overrides textDecorationStyles. Added a function to compute the textDecorationStyles. Added WPT ref test for painting unclashing lower priority text decoration over higher priority highlight without text decorations. * LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/painting/custom-highlight-painting-priority-text-decoration-001.html: Added. * Source/WebCore/rendering/StyledMarkedText.cpp: (WebCore::computeStylesForTextDecorations): (WebCore::coalesceAdjacentWithSameRanges): Canonical link: https://commits.webkit.org/266184@main
2bee93c
to
bf94cf5
Compare
Committed 266184@main (bf94cf5): https://commits.webkit.org/266184@main Reviewed commits have been landed. Closing PR #15919 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bf94cf5
2bee93c