Skip to content

[GTK][WPE] Fix clang warning in WebKitDownloadClient::legacyDidCancel() #16563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2023
Merged

[GTK][WPE] Fix clang warning in WebKitDownloadClient::legacyDidCancel() #16563

merged 1 commit into from
Aug 10, 2023

Conversation

@obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Aug 10, 2023 •
edited by webkit-early-warning-system
Loading

26d006a

[GTK][WPE] Fix clang warning in `WebKitDownloadClient::legacyDidCancel()`
https://bugs.webkit.org/show_bug.cgi?id=260023

Reviewed by Philippe Normand.

`WebKitDownloadClient::legacyDidCancel()` should be marked as `override`.

* Source/WebKit/UIProcess/API/glib/WebKitDownloadClient.cpp:

Canonical link: https://commits.webkit.org/266786@main

29949de

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@obyknovenius obyknovenius requested a review from a team as a code owner August 10, 2023 12:23
@obyknovenius obyknovenius self-assigned this Aug 10, 2023
@obyknovenius obyknovenius added the WPE WebKit WebKit WPE component label Aug 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 10, 2023 •
edited
Loading

EWS run on current version of this PR (hash 29949de)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Aug 10, 2023
@obyknovenius @mcatanzaro
[GTK][WPE] Fix clang warning in `WebKitDownloadClient::legacyDidCance…
26d006a 
…l()`

https://bugs.webkit.org/show_bug.cgi?id=260023

Reviewed by Philippe Normand.

`WebKitDownloadClient::legacyDidCancel()` should be marked as `override`.

* Source/WebKit/UIProcess/API/glib/WebKitDownloadClient.cpp:

Canonical link: https://commits.webkit.org/266786@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix/glib/clang/WebKitDownloadClient.cpp branch from 29949de to 26d006a Compare August 10, 2023 22:34
@webkit-commit-queue
Copy link
Collaborator

Committed 266786@main (26d006a): https://commits.webkit.org/266786@main

Reviewed commits have been landed. Closing PR #16563 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 26d006a into WebKit:main Aug 10, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 10, 2023
@obyknovenius obyknovenius deleted the fix/glib/clang/WebKitDownloadClient.cpp branch August 11, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philn philn philn approved these changes

Assignees

@obyknovenius obyknovenius

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@obyknovenius @webkit-early-warning-system @webkit-commit-queue @philn @mcatanzaro