Skip to content

[iOS] REGRESSION(268041@main): Unable to scroll Twitch.tv with touch atop video area #18081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2023
Merged

[iOS] REGRESSION(268041@main): Unable to scroll Twitch.tv with touch atop video area #18081

merged 1 commit into from
Sep 22, 2023

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented Sep 22, 2023 •
edited by webkit-early-warning-system
Loading

f64be53

[iOS] REGRESSION(268041@main): Unable to scroll Twitch.tv with touch atop video area
https://bugs.webkit.org/show_bug.cgi?id=261950
rdar://115850939

Reviewed by Simon Fraser.

Views which conform to WKNativelyInteractible (like WKModelView and WKSegmentedModelView) get special treatment inside `-_web_findDescendantViewAtPoint:`, so that touch events can be handled directly by the view itself. WKVideoView doesn't actually need to handle touch events directly, so it should just be a normal subclass of WKCompositingView.

* Source/WebKit/UIProcess/ios/WKVideoView.h:

Canonical link: https://commits.webkit.org/268331@main

6f25caf

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble requested a review from cdumez as a code owner September 22, 2023 15:33
@jernoble jernoble self-assigned this Sep 22, 2023
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label Sep 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 22, 2023 •
edited
Loading

EWS run on current version of this PR (hash 6f25caf)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble requested a review from smfr September 22, 2023 16:55
@aeharding aeharding mentioned this pull request Sep 22, 2023
Closed
@jernoble
Copy link
Contributor Author

I've been unable to reduce the twitch.tv behavior down to a test case. Tracking that issue in https://bugs.webkit.org/show_bug.cgi?id=261965.

@jernoble jernoble added the merge-queue Applied to send a pull request to merge-queue label Sep 22, 2023
@jernoble
[iOS] REGRESSION(268041@main): Unable to scroll Twitch.tv with touch …
f64be53 
…atop video area

https://bugs.webkit.org/show_bug.cgi?id=261950
rdar://115850939

Reviewed by Simon Fraser.

Views which conform to WKNativelyInteractible (like WKModelView and WKSegmentedModelView) get special treatment inside `-_web_findDescendantViewAtPoint:`, so that touch events can be handled directly by the view itself. WKVideoView doesn't actually need to handle touch events directly, so it should just be a normal subclass of WKCompositingView.

* Source/WebKit/UIProcess/ios/WKVideoView.h:

Canonical link: https://commits.webkit.org/268331@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/iOS-REGRESSION268041main-Unable-to-scroll-Twitch-tv-with-touch-atop-video-area branch from 6f25caf to f64be53 Compare September 22, 2023 20:54
@webkit-commit-queue webkit-commit-queue merged commit f64be53 into WebKit:main Sep 22, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 268331@main (f64be53): https://commits.webkit.org/268331@main

Reviewed commits have been landed. Closing PR #18081 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smfr smfr smfr approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@jernoble jernoble

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jernoble @webkit-early-warning-system @webkit-commit-queue @smfr