Skip to content

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Nov 2, 2023

72f76d9

Remove FetchAPIEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=264118
rdar://117880701

Reviewed by Brent Fulgham.

There's no need for this and all the API accessors for this preference
already no-op.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/fetch/FetchBody.idl:
* Source/WebCore/Modules/fetch/FetchRequest.idl:
* Source/WebCore/Modules/fetch/FetchResponse.idl:
* Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScope+Fetch.idl:

Canonical link: https://commits.webkit.org/270156@main

1dca9ec

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
🛠 watch-sim ✅ 🧪 jsc-mips-tests

@annevk annevk self-assigned this Nov 2, 2023
@annevk annevk added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Nov 2, 2023
@annevk annevk requested a review from brentfulgham November 2, 2023 23:57
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good -- we should have removed it a while ago. It was considered as a Lockdown Mode toggle, but we found the hit to Web Compatibility was too great. We should have removed this back then.

r=me

@annevk annevk added the merge-queue Applied to send a pull request to merge-queue label Nov 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=264118
rdar://117880701

Reviewed by Brent Fulgham.

There's no need for this and all the API accessors for this preference
already no-op.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/fetch/FetchBody.idl:
* Source/WebCore/Modules/fetch/FetchRequest.idl:
* Source/WebCore/Modules/fetch/FetchResponse.idl:
* Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScope+Fetch.idl:

Canonical link: https://commits.webkit.org/270156@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-FetchAPIEnabled-preference branch from 1dca9ec to 72f76d9 Compare November 3, 2023 01:47
@webkit-commit-queue
Copy link
Collaborator

Committed 270156@main (72f76d9): https://commits.webkit.org/270156@main

Reviewed commits have been landed. Closing PR #19916 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 72f76d9 into WebKit:main Nov 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 3, 2023
@annevk annevk deleted the eng/Remove-FetchAPIEnabled-preference branch November 3, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants