Skip to content

Adopt new JIT permissions API #20383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Adopt new JIT permissions API #20383

merged 1 commit into from
Nov 14, 2023

Conversation

@justinmichaud
Copy link
Contributor

@justinmichaud justinmichaud commented Nov 12, 2023 •
edited by webkit-early-warning-system
Loading

7c5f5e8

Adopt new JIT permissions API
https://bugs.webkit.org/show_bug.cgi?id=264694
rdar://116544588

Reviewed by Wenson Hsieh.

Adopt new JIT permissions API. This is more secure than the one we were
previously using.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/Configurations/WebCore.xcconfig:

Canonical link: https://commits.webkit.org/270693@main

09f0c2f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@justinmichaud justinmichaud requested a review from a team as a code owner November 12, 2023 02:51
@justinmichaud justinmichaud self-assigned this Nov 12, 2023
@justinmichaud justinmichaud added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Nov 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 12, 2023 •
edited
Loading

EWS run on previous version of this PR (hash d953143)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
❌ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
❌ 🛠 🧪 jsc-arm64 ❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 12, 2023
@justinmichaud justinmichaud removed the merging-blocked Applied to prevent a change from being merged label Nov 13, 2023
@justinmichaud justinmichaud force-pushed the eng/Adopt-new-JIT-permissions-API branch from d953143 to 99eb608 Compare November 13, 2023 23:37
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 13, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 99eb608)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
⏳ 🛠 watch-sim

@justinmichaud justinmichaud force-pushed the eng/Adopt-new-JIT-permissions-API branch from 99eb608 to 09f0c2f Compare November 14, 2023 00:32
@justinmichaud justinmichaud added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Nov 14, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 14, 2023 •
edited
Loading

EWS run on current version of this PR (hash 09f0c2f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Nov 14, 2023
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #3277.

Adopt new JIT permissions API
7c5f5e8 
https://bugs.webkit.org/show_bug.cgi?id=264694
rdar://116544588

Reviewed by Wenson Hsieh.

Adopt new JIT permissions API. This is more secure than the one we were
previously using.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/Configurations/WebCore.xcconfig:

Canonical link: https://commits.webkit.org/270693@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-new-JIT-permissions-API branch from 09f0c2f to 7c5f5e8 Compare November 14, 2023 06:42
@webkit-commit-queue
Copy link
Collaborator

Committed 270693@main (7c5f5e8): https://commits.webkit.org/270693@main

Reviewed commits have been landed. Closing PR #20383 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7c5f5e8 into WebKit:main Nov 14, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 14, 2023
@justinmichaud justinmichaud deleted the eng/Adopt-new-JIT-permissions-API branch April 12, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whsieh whsieh whsieh approved these changes

Assignees

@justinmichaud justinmichaud

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinmichaud @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @whsieh