Skip to content

[GTK][WPE] On the EWS for layout tests we should call the update-libs step before building webkit without patch #20504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

[GTK][WPE] On the EWS for layout tests we should call the update-libs step before building webkit without patch #20504

merged 1 commit into from
Nov 15, 2023

Conversation

clopez
Copy link
Contributor

@clopez clopez commented Nov 14, 2023 •
edited by webkit-early-warning-system
Loading

04402fa

[GTK][WPE] On the EWS for layout tests we should call the update-libs step before building webkit without patch
https://bugs.webkit.org/show_bug.cgi?id=264837

Reviewed by Carlos Garcia Campos.

The Layout Test EWS for the GTK and WPE ports should call the
script to update third party libraries before building WebKit
without patch.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTestsRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree.evaluateCommand):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestRunWebKitTestsRedTree.test_last_try_unexpected_failure_without_list_of_failing_tests_then_schedule_update_libs_and_test_without_patch):
(TestRunWebKitTestsRedTree):
(TestRunWebKitTestsRedTree.test_flakies_but_no_failures_then_go_to_analyze_results):
(TestRunWebKitTestsRepeatFailuresRedTree.test_last_run_with_patch_ends_with_list_of_failing_tests_then_schedule_update_libs_and_test_without_patch):
(TestRunWebKitTestsRepeatFailuresRedTree):
(TestRunWebKitTestsRepeatFailuresRedTree.test_last_run_with_patch_ends_with_no_failing_tests_then_go_to_analyze):

Canonical link: https://commits.webkit.org/270769@main

b744526

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@clopez clopez self-assigned this Nov 14, 2023
@clopez clopez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Nov 14, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 14, 2023 •
edited
Loading

EWS run on current version of this PR (hash b744526)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@clopez clopez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 15, 2023
@clopez
[GTK][WPE] On the EWS for layout tests we should call the update-libs…
04402fa 
… step before building webkit without patch

https://bugs.webkit.org/show_bug.cgi?id=264837

Reviewed by Carlos Garcia Campos.

The Layout Test EWS for the GTK and WPE ports should call the
script to update third party libraries before building WebKit
without patch.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTestsRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree.evaluateCommand):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestRunWebKitTestsRedTree.test_last_try_unexpected_failure_without_list_of_failing_tests_then_schedule_update_libs_and_test_without_patch):
(TestRunWebKitTestsRedTree):
(TestRunWebKitTestsRedTree.test_flakies_but_no_failures_then_go_to_analyze_results):
(TestRunWebKitTestsRepeatFailuresRedTree.test_last_run_with_patch_ends_with_list_of_failing_tests_then_schedule_update_libs_and_test_without_patch):
(TestRunWebKitTestsRepeatFailuresRedTree):
(TestRunWebKitTestsRepeatFailuresRedTree.test_last_run_with_patch_ends_with_no_failing_tests_then_go_to_analyze):

Canonical link: https://commits.webkit.org/270769@main
@webkit-commit-queue
Copy link
Collaborator

Committed 270769@main (04402fa): https://commits.webkit.org/270769@main

Reviewed commits have been landed. Closing PR #20504 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 04402fa into WebKit:main Nov 15, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@aj062 aj062 Awaiting requested review from aj062 aj062 is a code owner

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

Assignees

@clopez clopez

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clopez @webkit-early-warning-system @webkit-commit-queue @carlosgcampos