Regression(270725@main) Many Web extensions API tests are crashing #20548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeenon
added
the
New Bugs
|
EWS run on previous version of this PR (hash 9d7547a) |
xeenon
changed the title
xeenon
added
WebKit Extensions
|
EWS run on previous version of this PR (hash b428bfd) |
cdumez
reviewed
Nov 15, 2023
Source/WTF/wtf/OptionSet.h
Outdated
There was a problem hiding this comment.
This looks risky. It is setting all the bits, including the ones that don't have a valid enum value.
I could see how this function might return incorrect result as a result:
constexpr bool containsAll(OptionSet optionSet) const
{
return (*this & optionSet) == optionSet;
}
There was a problem hiding this comment.
fromRaw makes the input to only valid options. return OptionSet(static_cast<E>(maskRawValue<E>(rawValue)), FromRawValue);
There was a problem hiding this comment.
Indeed, I had missed that 👍🏻
martadarbinyan
approved these changes
Nov 15, 2023
xeenon
added
unsafe-merge-queue
|
EWS run on current version of this PR (hash bd4eb2d)
|
xeenon
added
the
unsafe-merge-queue
https://webkit.org/b/264885 rdar://problem/118464397 Reviewed by Chris Dumez. Remove the None and All values from Web Extension OptionSet enums, and use new OptionSet::all() instead to get a valid OptionSet for the given enum. Add back the EnumTraits for the OptionSets, since GeneratedSerializers does not generate them, and they are needed by OptionSet to check valid values. * Source/WTF/wtf/OptionSet.h: (WTF::OptionSet::all): Added. * Source/WebKit/Shared/Extensions/WebExtensionWindow.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (toImpl): * Source/WebKit/UIProcess/Extensions/WebExtensionTab.h: * Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm: (WebKit::WebExtensionAPIWindows::parseWindowTypesFilter): (WebKit::toWindowTypeFilter): (WebKit::WebExtensionContextProxy::dispatchWindowsEvent): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsEventCocoa.mm: (WebKit::WebExtensionAPIWindowsEvent::invokeListenersWithArgument): * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindowsEvent.h: Canonical link: https://commits.webkit.org/270782@main
webkit-commit-queue
force-pushed
the
bug/264884
branch
from
bd4eb2d to
5effaab
Compare
|
Committed 270782@main (5effaab): https://commits.webkit.org/270782@main Reviewed commits have been landed. Closing PR #20548 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5effaab
bd4eb2d
🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🛠 gtk🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🛠 🧪 jsc🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 🧪 jsc-arm64🛠 tv🧪 mac-AS-debug-wk2🛠 jsc-armv7🛠 tv-sim🧪 mac-wk2-stress🧪 jsc-armv7-tests🛠 watch🛠 watch-sim