-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[WPE] Fix build with GLib older than 2.74 #21275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash e5146e2)
|
e5146e2
to
0cd4048
Compare
EWS run on previous version of this PR (hash 0cd4048) |
0cd4048
to
df11590
Compare
https://bugs.webkit.org/show_bug.cgi?id=265286 Unreviewed build fix. While 271376@main attempted to fix g_io_unix_fd_list_get() being undefined with versions of GLib older than 2.74, it still resulted in build issues in some cases. This changes the included header to the <gio/gunixfdlist.h> one listed in the documentation. * Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp: Include gio/gunixfdlist.h as per the documentation instead of glib-unix.h. Canonical link: https://commits.webkit.org/271511@main
df11590
to
9063294
Compare
EWS run on current version of this PR (hash df11590)
|
Committed 271511@main (9063294): https://commits.webkit.org/271511@main Reviewed commits have been landed. Closing PR #21275 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9063294
df11590
🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 gtk🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🧪 mac-wk2-stress🛠 watch🛠 watch-sim