Skip to content

[:has() pseudo-class] Support invalidation for :any-link, :link and :-webkit-any-link #21663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

[:has() pseudo-class] Support invalidation for :any-link, :link and :-webkit-any-link #21663

merged 1 commit into from
Dec 12, 2023

Conversation

@nt1m
Copy link
Member

@nt1m nt1m commented Dec 12, 2023 •
edited by webkit-early-warning-system
Loading

1d40c07

[:has() pseudo-class] Support invalidation for :any-link, :link and :-webkit-any-link
https://bugs.webkit.org/show_bug.cgi?id=262836
rdar://116616425

Reviewed by Darin Adler.

Move Node::isLink/setIsLink to Element, and make use of Style::PseudoClassChangeInvalidation in the setter.

Add a web platform test as well.

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-class-in-has-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-class-in-has.html: Added.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setIsLink):
* Source/WebCore/dom/Element.h:
(WebCore::Element::isLink const):
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
* Source/WebCore/dom/Node.h:
(WebCore::Node::isLink const): Deleted.
(WebCore::Node::setIsLink): Deleted.
* Source/WebCore/editing/Editing.cpp:
(WebCore::enclosingAnchorElement):
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::attributeChanged):
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::disallowTelephoneNumberParsing):
* Source/WebCore/mathml/MathMLElement.cpp:
(WebCore::MathMLElement::attributeChanged):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect const):
* Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::svgAttributeChanged):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
* Source/WebKitLegacy/mac/DOM/DOM.mm:
(-[DOMNode _linkElement]):

Canonical link: https://commits.webkit.org/271919@main

384cf40

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m requested review from cdumez and rniwa as code owners December 12, 2023 05:39
@nt1m nt1m self-assigned this Dec 12, 2023
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Dec 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on previous version of this PR (hash faa23e5)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 gtk
❌ 🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
❌ 🛠 watch-sim

@nt1m nt1m force-pushed the eng/has-pseudo-class-Support-invalidation-for-any-link-link-and--webkit-any-link branch from faa23e5 to 0cc388d Compare December 12, 2023 05:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 0cc388d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac   🛠 wpe   🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   🛠 gtk
❌ 🧪 api-ios ❌ 🧪 mac-wk2   🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ❌ 🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim ❌ 🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

darinadler
darinadler approved these changes Dec 12, 2023
View reviewed changes
Source/WebCore/rendering/RenderObject.cpp Outdated
Copy link
Member

@darinadler darinadler Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just node() is fine now. The this-> was needed in the old code because the name node was also a local variable.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@nt1m nt1m force-pushed the eng/has-pseudo-class-Support-invalidation-for-any-link-link-and--webkit-any-link branch from 0cc388d to 236611c Compare December 12, 2023 06:00
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on current version of this PR (hash 236611c)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style loading 🛠 ios loading 🛠 mac loading 🛠 wpe ⏳ 🛠 wincairo
loading 🧪 bindings loading 🛠 ios-sim ⏳ 🛠 mac-AS-debug loading 🧪 wpe-wk2
loading 🧪 webkitperl loading 🧪 ios-wk2 loading 🧪 api-mac loading 🧪 api-wpe
loading 🧪 ios-wk2-wpt loading 🧪 mac-wk1 loading 🛠 gtk
loading 🧪 api-ios loading 🧪 mac-wk2 loading 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 loading 🧪 api-gtk
loading 🧪 services ⏳ 🛠 tv-sim loading 🧪 mac-wk2-stress loading 🛠 jsc-armv7
⏳ 🛠 watch loading 🧪 jsc-armv7-tests
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 236611c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios   🛠 mac ❌ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 gtk
❌ 🧪 api-ios   🧪 mac-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
❌ 🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
  🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@nt1m nt1m force-pushed the eng/has-pseudo-class-Support-invalidation-for-any-link-link-and--webkit-any-link branch from 236611c to a21efb6 Compare December 12, 2023 06:21
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a21efb6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
❌ 🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
❌ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
❌ 🛠 tv-sim   🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged labels Dec 12, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 12, 2023
@nt1m nt1m removed merging-blocked Applied to prevent a change from being merged safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Dec 12, 2023
@nt1m nt1m force-pushed the eng/has-pseudo-class-Support-invalidation-for-any-link-link-and--webkit-any-link branch from a21efb6 to 84b95a8 Compare December 12, 2023 06:44
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 84b95a8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Dec 12, 2023
annevk
annevk reviewed Dec 12, 2023
View reviewed changes
@nt1m nt1m force-pushed the eng/has-pseudo-class-Support-invalidation-for-any-link-link-and--webkit-any-link branch from 84b95a8 to 384cf40 Compare December 12, 2023 07:57
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on current version of this PR (hash 384cf40)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@nt1m nt1m added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Dec 12, 2023
@nt1m
[:has() pseudo-class] Support invalidation for :any-link, :link and :…
1d40c07 
…-webkit-any-link

https://bugs.webkit.org/show_bug.cgi?id=262836
rdar://116616425

Reviewed by Darin Adler.

Move Node::isLink/setIsLink to Element, and make use of Style::PseudoClassChangeInvalidation in the setter.

Add a web platform test as well.

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-class-in-has-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-class-in-has.html: Added.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setIsLink):
* Source/WebCore/dom/Element.h:
(WebCore::Element::isLink const):
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
* Source/WebCore/dom/Node.h:
(WebCore::Node::isLink const): Deleted.
(WebCore::Node::setIsLink): Deleted.
* Source/WebCore/editing/Editing.cpp:
(WebCore::enclosingAnchorElement):
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::attributeChanged):
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::disallowTelephoneNumberParsing):
* Source/WebCore/mathml/MathMLElement.cpp:
(WebCore::MathMLElement::attributeChanged):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect const):
* Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::svgAttributeChanged):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
* Source/WebKitLegacy/mac/DOM/DOM.mm:
(-[DOMNode _linkElement]):

Canonical link: https://commits.webkit.org/271919@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/has-pseudo-class-Support-invalidation-for-any-link-link-and--webkit-any-link branch from 384cf40 to 1d40c07 Compare December 12, 2023 09:17
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Dec 12, 2023

Committed 271919@main (1d40c07): https://commits.webkit.org/271919@main

Reviewed commits have been landed. Closing PR #21663 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1d40c07 into WebKit:main Dec 12, 2023
@webkit-commit-queue webkit-commit-queue removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Dec 12, 2023
@nt1m nt1m deleted the eng/has-pseudo-class-Support-invalidation-for-any-link-link-and--webkit-any-link branch December 12, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk left review comments

@darinadler darinadler darinadler approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@smfr smfr Awaiting requested review from smfr

@anttijk anttijk Awaiting requested review from anttijk

@heycam heycam Awaiting requested review from heycam

Assignees

@nt1m nt1m

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nt1m @webkit-early-warning-system @webkit-commit-queue @annevk @darinadler @webkit-ews-buildbot