Skip to content

Allow parsing of overflow-anchor behind flag #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2022
Merged

Allow parsing of overflow-anchor behind flag #2604

merged 1 commit into from
Jul 28, 2022

Conversation

nmoucht
Copy link
Contributor

@nmoucht nmoucht commented Jul 21, 2022 •
edited
Loading

397d2db

Allow parsing of overflow-anchor behind flag
https://bugs.webkit.org/show_bug.cgi?id=242973
<rdar://97694545>

Reviewed by NOBODY (OOPS!).

Add flag for scroll anchoring and allow parsing of overflow-anchor behind
that flag.

* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/parsing/overflow-anchor-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/parsing/overflow-anchor-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator OverflowAnchor const):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeOverflowAnchor):
(WebCore::CSSPropertyParser::parseSingleValue):
* Source/WebCore/platform/ScrollTypes.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/ScrollTypes.h:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::overflowAnchor const):
(WebCore::RenderStyle::setOverflowAnchor):
(WebCore::RenderStyle::initialOverflowAnchor):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:

@nmoucht nmoucht self-assigned this Jul 21, 2022
@nmoucht nmoucht added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Jul 21, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 21, 2022
@nmoucht nmoucht removed the merging-blocked Applied to prevent a change from being merged label Jul 21, 2022
@nmoucht nmoucht force-pushed the eng/Allow-parsing-of-overflow-anchor-behind-flag branch from ce29c9e to 52f811d Compare July 21, 2022 23:33
@nmoucht nmoucht requested a review from smfr July 21, 2022 23:34
smfr
smfr approved these changes Jul 21, 2022
View reviewed changes
@nmoucht nmoucht force-pushed the eng/Allow-parsing-of-overflow-anchor-behind-flag branch from 52f811d to d56cbcd Compare July 21, 2022 23:49
nt1m
nt1m reviewed Jul 21, 2022
View reviewed changes
@nmoucht nmoucht force-pushed the eng/Allow-parsing-of-overflow-anchor-behind-flag branch from d56cbcd to 536aa5c Compare July 22, 2022 04:14
nt1m
nt1m requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d70cd13 changed the way CSS property settings work, you may want to follow examples in there.

@nmoucht
Copy link
Contributor Author

nmoucht commented Jul 22, 2022

d70cd13 changed the way CSS property settings work, you may want to follow examples in there.

Yeah from my understanding the only thing relevant that changed was that I no longer have to check the setting in switch statement that is parsing the particular css property right? Is there anything clearly wrong with the patch as it is?

nt1m
nt1m reviewed Jul 22, 2022
View reviewed changes
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 22, 2022
@nmoucht nmoucht removed the merging-blocked Applied to prevent a change from being merged label Jul 22, 2022
@nmoucht nmoucht force-pushed the eng/Allow-parsing-of-overflow-anchor-behind-flag branch from 536aa5c to a7a9200 Compare July 22, 2022 08:53
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 22, 2022
nt1m
nt1m approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you've manually tested the preference works (the new mechanism is new to me as well, so I'm not 100% sure)

@nmoucht nmoucht removed the merging-blocked Applied to prevent a change from being merged label Jul 27, 2022
@nmoucht nmoucht force-pushed the eng/Allow-parsing-of-overflow-anchor-behind-flag branch from a7a9200 to f9e591b Compare July 27, 2022 21:41
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 28, 2022
@nmoucht nmoucht added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jul 28, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Allow-parsing-of-overflow-anchor-behind-flag branch from f9e591b to bd82777 Compare July 28, 2022 08:38
@nmoucht
Allow parsing of overflow-anchor behind flag
3d0806d 
https://bugs.webkit.org/show_bug.cgi?id=242973

Reviewed by Simon Fraser and Tim Nguyen.

Add flag for scroll anchoring and allow parsing of overflow-anchor behind
that flag.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator OverflowAnchor const):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeOverflowAnchor):
(WebCore::CSSPropertyParser::parseSingleValue):
* Source/WebCore/platform/ScrollTypes.h:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::overflowAnchor const):
(WebCore::RenderStyle::setOverflowAnchor):
(WebCore::RenderStyle::initialOverflowAnchor):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:

Canonical link: https://commits.webkit.org/252906@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Allow-parsing-of-overflow-anchor-behind-flag branch from bd82777 to 3d0806d Compare July 28, 2022 08:40
@webkit-commit-queue
Copy link
Collaborator

Committed 252906@main (3d0806d): https://commits.webkit.org/252906@main

Reviewed commits have been landed. Closing PR #2604 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 3d0806d into WebKit:main Jul 28, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smfr smfr smfr approved these changes

@nt1m nt1m nt1m approved these changes

Assignees

@nmoucht nmoucht

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nmoucht @webkit-commit-queue @smfr @nt1m @webkit-early-warning-system