-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[WPE] WPE Platform: change the API to get the preferred DMA-BUF formats #27255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPE] WPE Platform: change the API to get the preferred DMA-BUF formats #27255
Conversation
|
EWS run on previous version of this PR (hash fdcb30e)
|
fdcb30e to
dce70cd
Compare
|
EWS run on previous version of this PR (hash dce70cd)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great addition.
dce70cd to
08fb2b3
Compare
|
EWS run on current version of this PR (hash 08fb2b3)
|
https://bugs.webkit.org/show_bug.cgi?id=272667 Reviewed by Alejandro G. Castro. The initial API we added was very simple, just providing a single list of formats, usages and modifiers, but it turned out it was not so simple to iterate the formats, since we always want to iterate by tranche. Also, we want to handle the main and target devices in the future, so we need a new API that simplifies the iteration by tranche and includes the devices. * Source/WebKit/Shared/glib/DMABufRendererBufferFormat.h: (WebKit::DMABufRendererBufferFormat::operator== const): Deleted. * Source/WebKit/Shared/glib/DMABufRendererBufferFormat.serialization.in: * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::preferredBufferFormats const): * Source/WebKit/WPEPlatform/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/WPEBufferDMABufFormat.cpp: Removed. * Source/WebKit/WPEPlatform/wpe/WPEBufferDMABufFormat.h: Removed. * Source/WebKit/WPEPlatform/wpe/WPEBufferDMABufFormats.cpp: Added. (DMABufFormat::DMABufFormat): (DMABufFormatsGroup::DMABufFormatsGroup): (wpe_buffer_dma_buf_formats_class_init): (wpe_buffer_dma_buf_formats_get_device): (wpe_buffer_dma_buf_formats_get_n_groups): (wpe_buffer_dma_buf_formats_get_group_usage): (wpe_buffer_dma_buf_formats_get_group_device): (wpe_buffer_dma_buf_formats_get_group_n_formats): (wpe_buffer_dma_buf_formats_get_format_fourcc): (wpe_buffer_dma_buf_formats_get_format_modifiers): (_WPEBufferDMABufFormatsBuilder::_WPEBufferDMABufFormatsBuilder): (wpe_buffer_dma_buf_formats_builder_new): (wpe_buffer_dma_buf_formats_builder_ref): (wpe_buffer_dma_buf_formats_builder_unref): (wpe_buffer_dma_buf_formats_builder_append_group): (wpe_buffer_dma_buf_formats_builder_append_format): (wpe_buffer_dma_buf_formats_builder_end): * Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp: (wpeDisplayDispose): (wpeDisplayPreferredDMABufFormats): (wpe_display_get_preferred_dma_buf_formats): * Source/WebKit/WPEPlatform/wpe/WPEDisplay.h: * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_class_init): (wpe_view_get_preferred_dma_buf_formats): (wpeViewDispose): Deleted. * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: (wpeDisplayDRMGetPreferredDMABufFormats): * Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp: (wpeDisplayHeadlessGetPreferredDMABufFormats): * Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp: (wpeDisplayWaylandGetPreferredDMABufFormats): * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (DMABufFeedback::DMABufFeedback): (DMABufFeedback::drmDeviceForUsage): (DMABufFeedback::drmDevice const): (DMABufFeedback::Tranche::Tranche): (DMABufFeedback::Tranche::drmDevice const): (wpeViewWaylandGetPreferredDMABufFormats): * Source/WebKit/WPEPlatform/wpe/wpe-platform.h: * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp: (WebKit::AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create): (WebKit::AcceleratedSurfaceDMABuf::SwapChain::setupBufferFormat): * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h: Canonical link: https://commits.webkit.org/277538@main
08fb2b3 to
f78822d
Compare
|
Committed 277538@main (f78822d): https://commits.webkit.org/277538@main Reviewed commits have been landed. Closing PR #27255 and removing active labels. |
🧪 api-ios
f78822d
08fb2b3
🧪 api-mac🧪 ios-wk2-wpt🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2