Skip to content

[GTK] Build fix for GTK-Packaging-Nightly-Ubuntu2004 after 281106@main #30994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

[GTK] Build fix for GTK-Packaging-Nightly-Ubuntu2004 after 281106@main #30994

merged 1 commit into from
Jul 19, 2024

Conversation

dpino
Copy link
Contributor

@dpino dpino commented Jul 19, 2024 •
edited by webkit-early-warning-system
Loading

8e41578

[GTK] Build fix for GTK-Packaging-Nightly-Ubuntu2004 after 281106@main
https://bugs.webkit.org/show_bug.cgi?id=276741

Reviewed by Justin Michaud.

Add missing header 'unistd.h' and declare extern variable 'environ'.

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::initialize):

Canonical link: https://commits.webkit.org/281133@main

068e3d9

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@dpino dpino requested a review from a team as a code owner July 19, 2024 08:54
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 19, 2024 •
edited
Loading

EWS run on previous version of this PR (hash f265689)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ✅ 🛠 wincairo
  🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ❌ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision loading-orange 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress ❌ 🧪 api-gtk
  🧪 vision-wk2 ❌ 🛠 jsc-armv7
✅ 🛠 tv ❌ 🧪 jsc-armv7-tests
  🛠 tv-sim
✅ 🛠 watch
  🛠 watch-sim

@dpino dpino requested a review from justinmichaud July 19, 2024 08:54
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 19, 2024
@dpino dpino removed the merging-blocked Applied to prevent a change from being merged label Jul 19, 2024
@dpino dpino force-pushed the follow-up/281106@main branch from f265689 to 068e3d9 Compare July 19, 2024 09:08
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 19, 2024 •
edited
Loading

EWS run on current version of this PR (hash 068e3d9)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@dpino dpino self-assigned this Jul 19, 2024
justinmichaud
justinmichaud approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@dpino dpino added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 19, 2024
@dpino
[GTK] Build fix for GTK-Packaging-Nightly-Ubuntu2004 after 281106@main
8e41578 
https://bugs.webkit.org/show_bug.cgi?id=276741

Reviewed by Justin Michaud.

Add missing header 'unistd.h' and declare extern variable 'environ'.

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::initialize):

Canonical link: https://commits.webkit.org/281133@main
@webkit-commit-queue
Copy link
Collaborator

Committed 281133@main (8e41578): https://commits.webkit.org/281133@main

Reviewed commits have been landed. Closing PR #30994 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8e41578 into WebKit:main Jul 19, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 19, 2024
@dpino dpino deleted the follow-up/281106@main branch July 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmichaud justinmichaud justinmichaud approved these changes

Assignees

@dpino dpino

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dpino @webkit-early-warning-system @webkit-commit-queue @justinmichaud @webkit-ews-buildbot