Skip to content

Conversation

@csaavedra
Copy link
Member

@csaavedra csaavedra commented Jul 25, 2024

7d0cc75

Adopt smart pointers in a couple of ContainerNodeAlgorithms methods
https://bugs.webkit.org/show_bug.cgi?id=277077

Reviewed by Chris Dumez.

Fixes warning: Local variable 'shadowRoot' is uncounted and unsafe [clang-analyzer-alpha.webkit.UncountedLocalVarsChecker]

* Source/WebCore/dom/ContainerNodeAlgorithms.cpp:
(WebCore::collectFrameOwners):
(WebCore::disconnectSubframes):

Canonical link: https://commits.webkit.org/281354@main

f28a475

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@csaavedra csaavedra requested review from cdumez and rniwa as code owners July 25, 2024 12:47
@csaavedra csaavedra self-assigned this Jul 25, 2024
@csaavedra csaavedra added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Jul 25, 2024
@csaavedra csaavedra added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jul 25, 2024
@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jul 25, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #27696.

@webkit-ews-buildbot webkit-ews-buildbot added the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2024
https://bugs.webkit.org/show_bug.cgi?id=277077

Reviewed by Chris Dumez.

Fixes warning: Local variable 'shadowRoot' is uncounted and unsafe [clang-analyzer-alpha.webkit.UncountedLocalVarsChecker]

* Source/WebCore/dom/ContainerNodeAlgorithms.cpp:
(WebCore::collectFrameOwners):
(WebCore::disconnectSubframes):

Canonical link: https://commits.webkit.org/281354@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-smart-pointers-in-a-couple-of-ContainerNodeAlgorithms-methods branch from f28a475 to 7d0cc75 Compare July 25, 2024 16:44
@webkit-commit-queue
Copy link
Collaborator

Committed 281354@main (7d0cc75): https://commits.webkit.org/281354@main

Reviewed commits have been landed. Closing PR #31224 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7d0cc75 into WebKit:main Jul 25, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants