Skip to content

Fix ENABLE_DOCUMENTATION with missing gi-docgen error message #31251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix ENABLE_DOCUMENTATION with missing gi-docgen error message #31251

merged 1 commit into from
Jul 26, 2024

Conversation

@icesfont
Copy link
Contributor

@icesfont icesfont commented Jul 25, 2024 •
edited by webkit-early-warning-system
Loading

9f3babb

Fix ENABLE_DOCUMENTATION with missing gi-docgen error message

https://bugs.webkit.org/show_bug.cgi?id=277107

Reviewed by Michael Catanzaro.

Canonical link: https://commits.webkit.org/281398@main

f19c00b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@icesfont icesfont requested a review from a team as a code owner July 25, 2024 23:56
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 25, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 6a929c3)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
  🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2   🧪 wincairo-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ⏳ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress ⏳ 🧪 api-gtk
  🧪 vision-wk2 ✅ 🛠 jsc-armv7
  🛠 tv ⏳ 🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@icesfont icesfont changed the title Need a short description (OOPS!). Fix ENABLE_DOCUMENTATION with missing gi-docgen error message in OptionsGTK.cmake Jul 25, 2024
@icesfont icesfont changed the title Fix ENABLE_DOCUMENTATION with missing gi-docgen error message in OptionsGTK.cmake Fix ENABLE_DOCUMENTATION with missing gi-docgen error message Jul 26, 2024
@icesfont icesfont force-pushed the eng/Fix-ENABLE_DOCUMENTATION-with-missing-gi-docgen-error-message-in-OptionsGTK-cmake branch from 6a929c3 to 96d0c97 Compare July 26, 2024 00:00
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 96d0c97)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2   🧪 wincairo-tests
  🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ⏳ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
  🛠 🧪 jsc-arm64 ✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
  🧪 vision-wk2 ✅ 🛠 jsc-armv7
  🛠 tv ⏳ 🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@icesfont icesfont force-pushed the eng/Fix-ENABLE_DOCUMENTATION-with-missing-gi-docgen-error-message-in-OptionsGTK-cmake branch from 96d0c97 to 48b8e08 Compare July 26, 2024 00:05
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 26, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 48b8e08)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🛠 🧪 jsc ⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@icesfont icesfont changed the title Fix ENABLE_DOCUMENTATION with missing gi-docgen error message Fix ENABLE_DOCUMENTATION with missing gi-docgen error message in OptionsGTK.cmake Jul 26, 2024
@Ahmad-S792 Ahmad-S792 added the WebKitGTK Bugs related to the Gtk API layer. label Jul 26, 2024
mcatanzaro
mcatanzaro reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@mcatanzaro mcatanzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this fix! It's correct of course, but OptionsWPE.cmake has the exact same problem due to copy/paste. Would be great if you could fix that too please. (But don't add a second commit to this pull request. Rewrite the first commit with git commit --amend.)

@icesfont icesfont changed the title Fix ENABLE_DOCUMENTATION with missing gi-docgen error message in OptionsGTK.cmake Fix ENABLE_DOCUMENTATION with missing gi-docgen error message Jul 26, 2024
@icesfont icesfont force-pushed the eng/Fix-ENABLE_DOCUMENTATION-with-missing-gi-docgen-error-message-in-OptionsGTK-cmake branch from 48b8e08 to f19c00b Compare July 26, 2024 12:24
@icesfont
Copy link
Contributor Author

Got it, done!

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 26, 2024 •
edited
Loading

EWS run on current version of this PR (hash f19c00b)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Jul 26, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-ENABLE_DOCUMENTATION-with-missing-gi-docgen-error-message-in-OptionsGTK-cmake branch from f19c00b to 9f3babb Compare July 26, 2024 13:52
@webkit-commit-queue
Copy link
Collaborator

Committed 281398@main (9f3babb): https://commits.webkit.org/281398@main

Reviewed commits have been landed. Closing PR #31251 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9f3babb into WebKit:main Jul 26, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

Assignees

@icesfont icesfont

Labels

WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@icesfont @webkit-early-warning-system @webkit-commit-queue @mcatanzaro @Ahmad-S792