Skip to content

[web-animations] stroke-color should be animatable #31448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

[web-animations] stroke-color should be animatable #31448

merged 1 commit into from
Jul 30, 2024

Conversation

@nt1m
Copy link
Member

@nt1m nt1m commented Jul 30, 2024 •
edited by webkit-early-warning-system
Loading

858d667

[web-animations] stroke-color should be animatable
https://bugs.webkit.org/show_bug.cgi?id=277317
rdar://132784589

Reviewed by Darin Adler.

As per: https://drafts.fxtf.org/fill-stroke-3/#propdef-stroke-color

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::strokeColor const):

Canonical link: https://commits.webkit.org/281570@main

a3d4ad2

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested a review from graouts as a code owner July 30, 2024 06:28
@nt1m nt1m self-assigned this Jul 30, 2024
@nt1m nt1m added the Animations Bugs related to CSS + SVG animations and transitions label Jul 30, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 220e578)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/web-animations-stroke-color-should-be-animatable branch from 220e578 to ff0c1d1 Compare July 30, 2024 06:29
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on previous version of this PR (hash ff0c1d1)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/web-animations-stroke-color-should-be-animatable branch from ff0c1d1 to 56bc2cf Compare July 30, 2024 06:39
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 56bc2cf)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
  🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/web-animations-stroke-color-should-be-animatable branch from 56bc2cf to a3d4ad2 Compare July 30, 2024 06:41
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on current version of this PR (hash a3d4ad2)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from darinadler, heycam, mdubet and weinig July 30, 2024 08:14
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024
@nt1m nt1m added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jul 30, 2024
@nt1m
[web-animations] stroke-color should be animatable
858d667 
https://bugs.webkit.org/show_bug.cgi?id=277317
rdar://132784589

Reviewed by Darin Adler.

As per: https://drafts.fxtf.org/fill-stroke-3/#propdef-stroke-color

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::strokeColor const):

Canonical link: https://commits.webkit.org/281570@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/web-animations-stroke-color-should-be-animatable branch from a3d4ad2 to 858d667 Compare July 30, 2024 16:12
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jul 30, 2024

Committed 281570@main (858d667): https://commits.webkit.org/281570@main

Reviewed commits have been landed. Closing PR #31448 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 858d667 into WebKit:main Jul 30, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 30, 2024
@nt1m nt1m deleted the eng/web-animations-stroke-color-should-be-animatable branch July 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darinadler darinadler darinadler approved these changes

@graouts graouts Awaiting requested review from graouts graouts is a code owner

@heycam heycam Awaiting requested review from heycam

@weinig weinig Awaiting requested review from weinig

@mdubet mdubet Awaiting requested review from mdubet

Assignees

@nt1m nt1m

Labels

Animations Bugs related to CSS + SVG animations and transitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nt1m @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot