Make LengthSize and LengthPoint consistent #31753

NathanSolomon733 · 2024-08-05T23:14:50Z

`42049e8`

Make LengthSize and LengthPoint consistent
https://bugs.webkit.org/show_bug.cgi?id=277521
rdar://133228272

Reviewed by Tim Nguyen.

This fix  gets rid of using public/private control in LengthPoint, which was already a struct. It makes all members of LengthPoint public and removes their getter and setter members.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/css/BasicShapeConversion.cpp:
(WebCore::valueForBasicShape):
* Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp:
(WebCore::lengthPointToCSSValue):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForPosition):
(WebCore::isAuto):
(WebCore::isNormal):
(WebCore::valueForPathOperation):
* Source/WebCore/platform/LengthFunctions.cpp:
(WebCore::pointForLengthPoint):
(WebCore::floatPointForLengthPoint):
* Source/WebCore/platform/LengthPoint.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/LengthPoint.h:
(WebCore::LengthPoint::LengthPoint):
(WebCore::LengthPoint::isZero const):
(WebCore::blend):
(WebCore::LengthPoint::setX): Deleted.
(WebCore::LengthPoint::x const): Deleted.
(WebCore::LengthPoint::setY): Deleted.
(WebCore::LengthPoint::y const): Deleted.
* Source/WebCore/platform/animation/AcceleratedEffectValues.cpp:
(WebCore::nonCalculatedLengthPoint):
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
* Source/WebCore/rendering/MotionPath.cpp:
(WebCore::MotionPath::motionPathDataForRenderer):
(WebCore::MotionPath::applyMotionPathTransform):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebCore/rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
* Source/WebCore/rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x const):
(WebCore::ShadowData::y const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/284009@main

4b49aeb

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-08-05T23:15:54Z

EWS run on previous version of this PR (hash 4a91f5e)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-05T23:30:59Z

EWS run on previous version of this PR (hash 94c23bd)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	❌ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	❌ 🧪 mac-wk2	~~🛠 gtk~~
	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-05T23:40:39Z

EWS run on previous version of this PR (hash 8dcffb4)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

Source/WebCore/platform/LengthPoint.h

webkit-early-warning-system · 2024-08-05T23:54:13Z

EWS run on previous version of this PR (hash aab947e)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T00:01:59Z

EWS run on previous version of this PR (hash ac596fa)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T00:10:40Z

EWS run on previous version of this PR (hash e32e087)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T01:10:32Z

EWS run on previous version of this PR (hash cb66757)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
~~🧪 bindings~~	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T01:25:30Z

EWS run on previous version of this PR (hash 93277f8)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2		🛠 jsc-armv7
	~~🛠 tv~~		🧪 jsc-armv7-tests
	❌ 🛠 tv-sim
	❌ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T04:50:46Z

EWS run on previous version of this PR (hash ac19196)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
~~🧪 bindings~~	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T04:55:00Z

EWS run on previous version of this PR (hash 26879d7)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	❌ 🛠 tv-sim
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T05:24:19Z

EWS run on previous version of this PR (hash 6ea237b)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	❌ 🛠 tv-sim
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T05:55:58Z

EWS run on previous version of this PR (hash 12a777d)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	❌ 🛠 ios-sim	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	❌ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-08-06T05:58:51Z

EWS run on previous version of this PR (hash 7319efe)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2
	❌ 🛠 tv
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

Source/WebCore/platform/LengthPoint.h

brentfulgham · 2024-08-06T17:05:38Z

Looks like rendering/style/ShadowData.h needs to be updated, too. You might want to get a full clean build locally before bothering to put a patch up, since there are likely tons of these small fix-ups needed.

webkit-early-warning-system · 2024-08-07T17:31:13Z

EWS run on previous version of this PR (hash 0dd91a9)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/platform/LengthPoint.h

webkit-early-warning-system · 2024-09-19T23:00:51Z

EWS run on previous version of this PR (hash 016ad20)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

Source/WebCore/platform/LengthPoint.h

webkit-early-warning-system · 2024-09-19T23:27:37Z

EWS run on previous version of this PR (hash c0268f4)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	❌ 🛠 tv
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-09-20T16:10:54Z

EWS run on current version of this PR (hash 4b49aeb)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2024-09-20T20:11:45Z

Safe-Merge-Queue: Build #33185.

https://bugs.webkit.org/show_bug.cgi?id=277521 rdar://133228272 Reviewed by Tim Nguyen. This fix gets rid of using public/private control in LengthPoint, which was already a struct. It makes all members of LengthPoint public and removes their getter and setter members. * Source/WebCore/animation/CSSPropertyAnimation.cpp: * Source/WebCore/css/BasicShapeConversion.cpp: (WebCore::valueForBasicShape): * Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp: (WebCore::lengthPointToCSSValue): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::valueForPosition): (WebCore::isAuto): (WebCore::isNormal): (WebCore::valueForPathOperation): * Source/WebCore/platform/LengthFunctions.cpp: (WebCore::pointForLengthPoint): (WebCore::floatPointForLengthPoint): * Source/WebCore/platform/LengthPoint.cpp: (WebCore::operator<<): * Source/WebCore/platform/LengthPoint.h: (WebCore::LengthPoint::LengthPoint): (WebCore::LengthPoint::isZero const): (WebCore::blend): (WebCore::LengthPoint::setX): Deleted. (WebCore::LengthPoint::x const): Deleted. (WebCore::LengthPoint::setY): Deleted. (WebCore::LengthPoint::y const): Deleted. * Source/WebCore/platform/animation/AcceleratedEffectValues.cpp: (WebCore::nonCalculatedLengthPoint): (WebCore::AcceleratedEffectValues::AcceleratedEffectValues): * Source/WebCore/rendering/MotionPath.cpp: (WebCore::MotionPath::motionPathDataForRenderer): (WebCore::MotionPath::applyMotionPathTransform): * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): * Source/WebCore/rendering/style/ShadowData.cpp: (WebCore::ShadowData::ShadowData): * Source/WebCore/rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::x const): (WebCore::ShadowData::y const): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/284009@main

webkit-commit-queue · 2024-09-20T20:40:10Z

Committed 284009@main (42049e8): https://commits.webkit.org/284009@main

Reviewed commits have been landed. Closing PR #31753 and removing active labels.

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 94c23bd to 8dcffb4 Compare August 5, 2024 23:40

smfr reviewed Aug 5, 2024

View reviewed changes

Source/WebCore/platform/LengthPoint.h Outdated Show resolved Hide resolved

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 8dcffb4 to aab947e Compare August 5, 2024 23:54

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from ac596fa to e32e087 Compare August 6, 2024 00:10

NathanSolomon733 marked this pull request as draft August 6, 2024 00:17

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 6, 2024

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from e32e087 to cb66757 Compare August 6, 2024 01:10

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from cb66757 to 93277f8 Compare August 6, 2024 01:25

NathanSolomon733 changed the title ~~Make LengthSize and LengthPoint consistent~~ Need a short description (OOPS!). Aug 6, 2024

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 93277f8 to ac19196 Compare August 6, 2024 04:50

NathanSolomon733 changed the title ~~Need a short description (OOPS!).~~ Make LengthSize and LengthPoint consistent Aug 6, 2024

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from ac19196 to 26879d7 Compare August 6, 2024 04:54

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 26879d7 to 6ea237b Compare August 6, 2024 05:24

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 6ea237b to 12a777d Compare August 6, 2024 05:55

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 12a777d to 7319efe Compare August 6, 2024 05:58

brentfulgham reviewed Aug 6, 2024

View reviewed changes

Source/WebCore/platform/LengthPoint.h Outdated Show resolved Hide resolved

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 1473f62 to 0dd91a9 Compare August 7, 2024 17:31

NathanSolomon733 marked this pull request as ready for review August 8, 2024 00:23

NathanSolomon733 requested a review from graouts as a code owner August 8, 2024 00:23

NathanSolomon733 marked this pull request as draft August 8, 2024 00:36

NathanSolomon733 marked this pull request as ready for review August 8, 2024 00:44

nt1m reviewed Aug 8, 2024

View reviewed changes

Source/WebCore/platform/LengthPoint.h Outdated Show resolved Hide resolved

Ahmad-S792 assigned NathanSolomon733 Aug 22, 2024

Ahmad-S792 added Layout and Rendering For bugs with layout and rendering of Web pages. and removed merging-blocked Applied to prevent a change from being merged labels Aug 22, 2024

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 0dd91a9 to 016ad20 Compare September 19, 2024 23:00

nt1m approved these changes Sep 19, 2024

View reviewed changes

Source/WebCore/platform/LengthPoint.h Outdated Show resolved Hide resolved

NathanSolomon733 marked this pull request as draft September 19, 2024 23:11

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 016ad20 to c0268f4 Compare September 19, 2024 23:27

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 20, 2024

NathanSolomon733 removed the merging-blocked Applied to prevent a change from being merged label Sep 20, 2024

NathanSolomon733 force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from c0268f4 to 4b49aeb Compare September 20, 2024 16:10

NathanSolomon733 marked this pull request as ready for review September 20, 2024 19:56

zakariaridouh added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Sep 20, 2024

webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Sep 20, 2024

webkit-commit-queue force-pushed the eng/Make-LengthSize-and-LengthPoint-consistent branch from 4b49aeb to 42049e8 Compare September 20, 2024 20:40

webkit-commit-queue merged commit 42049e8 into WebKit:main Sep 20, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 20, 2024

Make LengthSize and LengthPoint consistent #31753

Make LengthSize and LengthPoint consistent #31753

Uh oh!

Conversation

NathanSolomon733 commented Aug 5, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

42049e8

Uh oh!

webkit-early-warning-system commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

brentfulgham commented Aug 6, 2024

Uh oh!

webkit-early-warning-system commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Sep 20, 2024

Uh oh!

webkit-commit-queue commented Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

NathanSolomon733 commented Aug 5, 2024 •

edited by webkit-early-warning-system

Loading

`42049e8`

webkit-early-warning-system commented Aug 5, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 5, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 5, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 5, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2024 •

edited

Loading

webkit-early-warning-system commented Aug 7, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 19, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 19, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 20, 2024 •

edited

Loading