-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add a feature flag for supporting partitioned cookies #33728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
sysrqb
wants to merge
6
commits into
WebKit:main
from
sysrqb:eng/Initial-Partitioned-Cookie-Support_debug
Closed
Add a feature flag for supporting partitioned cookies #33728
sysrqb
wants to merge
6
commits into
WebKit:main
from
sysrqb:eng/Initial-Partitioned-Cookie-Support_debug
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on previous version of this PR (hash 0837984) |
Collaborator
|
EWS run on previous version of this PR (hash c3695e0) |
c3695e0 to
2f7cc78
Compare
Collaborator
|
EWS run on previous version of this PR (hash 2f7cc78) |
https://bugs.webkit.org/show_bug.cgi?id=279547 rdar://problem/135829408 Reviewed by NOBODY (OOPS!). This patch adds some initial tests that will cover support for opt-in partitioned cookies. The test expectations will be updated in the future. This patch also begins supporting partitioned cookies instead of blocking all third-party cookies, when the feature is enabled. This patch doesn't introduce any changes in the current behavior. * LayoutTests/TestExpectations: * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-and-non-partitioned-cookie-js-not-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-and-non-partitioned-cookie-js-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-and-non-partitioned-httponly-cookie-http-header-not-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-and-non-partitioned-httponly-cookie-http-header-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-and-non-partitioned-httponly-cookie-js-not-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-and-non-partitioned-httponly-cookie-js-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-cookie-http-header-not-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-cookie-http-header-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-cookie-js-not-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-cookie-js-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-httponly-cookie-http-header-not-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-httponly-cookie-http-header-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-httponly-cookie-js-not-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/resources/iframe-set-partitioned-httponly-cookie-js-secure.html: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-and-non-partitioned-cookie-expected.txt: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-and-non-partitioned-cookie.html: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-and-non-partitioned-cookie.https-expected.txt: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-and-non-partitioned-cookie.https.html: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-cookie-expected.txt: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-cookie.html: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-cookie.https-expected.txt: Added. * LayoutTests/http/tests/cookies/partitioned/set-partitioned-cookie.https.html: Added. * LayoutTests/http/tests/cookies/resources/cookie-utilities.js: * LayoutTests/http/tests/cookies/resources/setCookies.cgi: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/platform/Cookie.h: (WebCore::Cookie::isNull const): (WebCore::Cookie::Cookie): (WebCore::Cookie::isolatedCopy const): (WebCore::Cookie::isolatedCopy): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp: (WebKit::shouldBlockCookies): (WebKit::WebCookieJar::cookies const): (WebKit::WebCookieJar::setCookies): (WebKit::WebCookieJar::cookiesEnabled): (WebKit::WebCookieJar::cookieRequestHeaderFieldValue const): (WebKit::WebCookieJar::getRawCookies const): (WebKit::WebCookieJar::getCookiesAsync const): (WebKit::WebCookieJar::setCookieAsync const):
…w_bug.cgi?id=279547 rdar://problem/135829408
…w_bug.cgi?id=279547 rdar://problem/135829408
…w_bug.cgi?id=279547 rdar://problem/135829408
2f7cc78 to
13460af
Compare
Collaborator
|
EWS run on previous version of this PR (hash 13460af) |
….org/show_bug.cgi?id=279547 rdar://problem/135829408" This reverts commit 13460af.
…w_bug.cgi?id=279547 rdar://problem/135829408
Collaborator
|
EWS run on current version of this PR (hash 888fd47) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧪 jsc-armv7-tests
72e1a8685ace439f1209f8f449e73069a2398c89