Unreviewed, reverting 284276@main (290d009f7b35)

[magomez]

41cdaf7

Unreviewed, reverting 284276@main (290d009f7b35)
https://bugs.webkit.org/show_bug.cgi?id=281222

Broke the build in multiple platforms that can't provide the libspiel dependency

Reverted change:

    [WPE][GTK] Speech synthesis using libspiel
    https://bugs.webkit.org/show_bug.cgi?id=270742
    284276@main (290d009f7b35)

Canonical link: https://commits.webkit.org/285005@main

b180bc7

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
🛠 🧪 jsc	🧪 api-ios	🧪 mac-wk2	🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	🧪 mac-intel-wk2	🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 75162a5)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
🛠 🧪 jsc	🧪 api-ios	🧪 mac-wk2	🛠 gtk
🛠 🧪 jsc-arm64	✅ 🛠 vision	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	⏳ 🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv	🛠 mac-safer-cpp	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 47953ff)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	⏳ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
❌ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[philn]

As mentioned already, the flite support will be brought back using a cmake option. No need to revert this.

[magomez]

As mentioned already, the flite support will be brought back using a cmake option. No need to revert this.

@philn this has been broken for a while now, and has already consumed a lot of hours from people trying to workaround it one way or another. Please, let's just revert to end this problem and you can then, with more time, add a new version that supports both spiel and flite.

[mcatanzaro]

I don't understand how this can be taking hours of effort? It just requires a single build flag to disable?

In the absolute worst case where we're unable to change build flags for some extremely strange reason, we could simply define the feature to OFF rather than ON by default? That would surely solve things without needing to revert?

[webkit-commit-queue]

No reviewer information in commit message, blocking PR #34975. Details: Build #10915

[webkit-early-warning-system]

EWS run on current version of this PR (hash b180bc7)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
🛠 🧪 jsc	🧪 api-ios	🧪 mac-wk2	🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	🧪 mac-intel-wk2	🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 285005@main (41cdaf7): https://commits.webkit.org/285005@main

Reviewed commits have been landed. Closing PR #34975 and removing active labels.