Skip to content

Unreviewed, reverting 285011@main. #35606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Unreviewed, reverting 285011@main. #35606

merged 1 commit into from
Oct 23, 2024

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Oct 23, 2024 •
edited by webkit-early-warning-system
Loading

d794344

Unreviewed, reverting 285011@main.
https://bugs.webkit.org/show_bug.cgi?id=281950

Introduced a performance regression.

Reverted changeset:
"[CoordinatedGraphics] Simplify tiled backing store handling"
https://bugs.webkit.org/show_bug.cgi?id=280606
https://commits.webkit.org/285011@main

Canonical link: https://commits.webkit.org/285591@main

4576cca

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
  🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@carlosgcampos carlosgcampos self-assigned this Oct 23, 2024
@carlosgcampos carlosgcampos added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Oct 23, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 23, 2024 •
edited
Loading

EWS run on current version of this PR (hash 4576cca)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
  🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 23, 2024
@carlosgcampos carlosgcampos added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Oct 23, 2024
@carlosgcampos
Unreviewed, reverting 285011@main.
d794344 
https://bugs.webkit.org/show_bug.cgi?id=281950

Introduced a performance regression.

Reverted changeset:
"[CoordinatedGraphics] Simplify tiled backing store handling"
https://bugs.webkit.org/show_bug.cgi?id=280606
https://commits.webkit.org/285011@main

Canonical link: https://commits.webkit.org/285591@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Introduced-a-performance-regression branch from 4576cca to d794344 Compare October 23, 2024 08:04
@webkit-commit-queue
Copy link
Collaborator

Committed 285591@main (d794344): https://commits.webkit.org/285591@main

Reviewed commits have been landed. Closing PR #35606 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d794344 into WebKit:main Oct 23, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 23, 2024
@carlosgcampos carlosgcampos deleted the eng/Introduced-a-performance-regression branch October 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magomez magomez Awaiting requested review from magomez magomez is a code owner

@zdobersek zdobersek Awaiting requested review from zdobersek

Assignees

@carlosgcampos carlosgcampos

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlosgcampos @webkit-early-warning-system @webkit-commit-queue @webkit-ews-buildbot