Skip to content

Conversation

@whsieh
Copy link
Member

@whsieh whsieh commented Nov 12, 2024

0829e2f

weather.com: [macOS] Unable to dismiss drop-down after clicking on document body
https://bugs.webkit.org/show_bug.cgi?id=282965
rdar://138053733

Reviewed by Abrar Rahman Protyasha and Richard Robinson.

Augment an existing quirk to allow mouse clicks to `focus()` form controls (in this case, a `button`
element). weather.com depends on the button that shows the dropdown menu gaining focus when clicked,
since it dismisses the dropdown when the button loses focus (which, in turn, happens when the user
clicks on the body).

This is a long-standing behavior in WebKit, which (roughly) matches platform convention on macOS;
see https://webkit.org/b/22261 for more context.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsFormControlToBeMouseFocusable const):

Canonical link: https://commits.webkit.org/286468@main

761798a

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
🛠 watch
🛠 watch-sim

@whsieh whsieh requested a review from cdumez as a code owner November 12, 2024 02:15
@whsieh whsieh self-assigned this Nov 12, 2024
@whsieh whsieh added the UI Events For bugs related to user interactions like keyboard, mouse, and touch events. label Nov 12, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 12, 2024
@whsieh whsieh added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 12, 2024
@whsieh
Copy link
Member Author

whsieh commented Nov 12, 2024

Thanks for the reviews!

…cument body

https://bugs.webkit.org/show_bug.cgi?id=282965
rdar://138053733

Reviewed by Abrar Rahman Protyasha and Richard Robinson.

Augment an existing quirk to allow mouse clicks to `focus()` form controls (in this case, a `button`
element). weather.com depends on the button that shows the dropdown menu gaining focus when clicked,
since it dismisses the dropdown when the button loses focus (which, in turn, happens when the user
clicks on the body).

This is a long-standing behavior in WebKit, which (roughly) matches platform convention on macOS;
see https://webkit.org/b/22261 for more context.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsFormControlToBeMouseFocusable const):

Canonical link: https://commits.webkit.org/286468@main
@webkit-commit-queue
Copy link
Collaborator

Committed 286468@main (0829e2f): https://commits.webkit.org/286468@main

Reviewed commits have been landed. Closing PR #36516 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0829e2f into WebKit:main Nov 12, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 12, 2024
@whsieh whsieh deleted the eng/282965 branch November 12, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Events For bugs related to user interactions like keyboard, mouse, and touch events.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants