Skip to content

Conversation

@fujii
Copy link
Contributor

@fujii fujii commented Nov 15, 2024

31115c9

ASSERTION FAILED: m_start != m_end in WTF::Deque<WTF::String>::last() under WebCore::FragmentDirectiveParser::parseFragmentDirective
https://bugs.webkit.org/show_bug.cgi?id=282814

Reviewed by Tim Horton.

If a text directive consists of only the prefix but no start text, for
example <https://webkit.org/#:~:text=prefix->, a release assertion
failed.

* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment.html:
* Source/WebCore/dom/FragmentDirectiveParser.cpp:
(WebCore::FragmentDirectiveParser::parseFragmentDirective):

Canonical link: https://commits.webkit.org/286654@main

24b6748

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@fujii fujii requested review from cdumez and rniwa as code owners November 15, 2024 07:44
@fujii fujii self-assigned this Nov 15, 2024
@fujii fujii added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Nov 15, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 15, 2024
@fujii fujii added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Nov 15, 2024
… under WebCore::FragmentDirectiveParser::parseFragmentDirective

https://bugs.webkit.org/show_bug.cgi?id=282814

Reviewed by Tim Horton.

If a text directive consists of only the prefix but no start text, for
example <https://webkit.org/#:~:text=prefix->, a release assertion
failed.

* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment.html:
* Source/WebCore/dom/FragmentDirectiveParser.cpp:
(WebCore::FragmentDirectiveParser::parseFragmentDirective):

Canonical link: https://commits.webkit.org/286654@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ASSERTION-FAILED-m_start--m_end-in-WTFDequeWTFStringlast-under-WebCoreFragmentDirectiveParserparseFragmentDirective branch from 24b6748 to 31115c9 Compare November 15, 2024 21:58
@webkit-commit-queue
Copy link
Collaborator

Committed 286654@main (31115c9): https://commits.webkit.org/286654@main

Reviewed commits have been landed. Closing PR #36684 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 31115c9 into WebKit:main Nov 15, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 15, 2024
@fujii fujii deleted the eng/ASSERTION-FAILED-m_start--m_end-in-WTFDequeWTFStringlast-under-WebCoreFragmentDirectiveParserparseFragmentDirective branch November 17, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants