[CoordinatedGraphics] Use CoordinatedPlatformLayer in async scrolling #37825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgcampos
requested review from
cdumez,
magomez and
zdobersek
as code owners
carlosgcampos
added
the
Platform
|
EWS run on current version of this PR (hash add827c) |
webkit-ews-buildbot
added
the
merging-blocked
carlosgcampos
removed
the
merging-blocked
alexgcastro
approved these changes
Dec 13, 2024
carlosgcampos
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=284518 Reviewed by Alejandro G. Castro. * Source/WebCore/page/scrolling/ScrollingPlatformLayer.h: * Source/WebCore/page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::isScrollingTreeNicosia const): * Source/WebCore/page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: (WebCore::ScrollingCoordinatorNicosia::didCompletePlatformRenderingUpdate): * Source/WebCore/page/scrolling/nicosia/ScrollingStateNodeNicosia.cpp: (WebCore::LayerRepresentation::makePlatformLayerTyped): (WebCore::LayerRepresentation::makePlatformLayerTypeless): (WebCore::LayerRepresentation::platformLayerFromGraphicsLayer): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNodeNicosia.cpp: (WebCore::ScrollingTreeFixedNodeNicosia::commitStateBeforeChildren): (WebCore::ScrollingTreeFixedNodeNicosia::applyLayerPositions): (WebCore::ScrollingTreeFixedNodeNicosia::dumpProperties const): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNodeNicosia.h: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp: (WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateBeforeChildren): (WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers): (WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionRelatedLayers): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp: (WebCore::ScrollingTreeNicosia::applyLayerPositionsInternal): (WebCore::ScrollingTreeNicosia::didCompleteRenderingUpdate): (WebCore::ScrollingTreeNicosia::didCompletePlatformRenderingUpdate): (WebCore::collectDescendantLayersAtPoint): (WebCore::ScrollingTreeNicosia::scrollingNodeForPoint): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.h: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.cpp: (WebCore::ScrollingTreeOverflowScrollProxyNodeNicosia::commitStateBeforeChildren): (WebCore::ScrollingTreeOverflowScrollProxyNodeNicosia::applyLayerPositions): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollProxyNodeNicosia.h: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp: (WebCore::ScrollingTreeOverflowScrollingNodeNicosia::repositionScrollingLayers): * Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.cpp: (WebCore::ScrollingTreePositionedNodeNicosia::commitStateBeforeChildren): (WebCore::ScrollingTreePositionedNodeNicosia::applyLayerPositions): * Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.h: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.h: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNodeNicosia.cpp: (WebCore::ScrollingTreeStickyNodeNicosia::commitStateBeforeChildren): (WebCore::ScrollingTreeStickyNodeNicosia::applyLayerPositions): (WebCore::ScrollingTreeStickyNodeNicosia::layerTopLeft const): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNodeNicosia.h: * Source/WebCore/platform/SourcesNicosia.txt: * Source/WebCore/platform/TextureMapper.cmake: * Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.h: (Nicosia::PlatformLayer::setSceneIntegration): Deleted. (Nicosia::PlatformLayer::createUpdateScope): Deleted. * Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.cpp: Removed. * Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h: Removed. * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp: (WebCore::CoordinatedPlatformLayer::setPositionForScrolling): (WebCore::CoordinatedPlatformLayer::setTopLeftPositionForScrolling): (WebCore::CoordinatedPlatformLayer::topLeftPositionForScrolling): (WebCore::CoordinatedPlatformLayer::setBoundsOriginForScrolling): (WebCore::CoordinatedPlatformLayer::bounds const): (WebCore::CoordinatedPlatformLayer::setScrollingNodeID): (WebCore::CoordinatedPlatformLayer::scrollingNodeID const): (WebCore::CoordinatedPlatformLayer::children const): (WebCore::CoordinatedPlatformLayer::eventRegion const): (WebCore::CoordinatedPlatformLayer::isCompositionRequiredOrOngoing const): (WebCore::CoordinatedPlatformLayer::requestComposition): (WebCore::CoordinatedPlatformLayer::syncPosition): Deleted. (WebCore::CoordinatedPlatformLayer::syncBoundsOrigin): Deleted. * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.h: * Source/WebCore/platform/graphics/texmap/coordinated/GraphicsLayerCoordinated.cpp: (WebCore::GraphicsLayerCoordinated::syncPosition): (WebCore::GraphicsLayerCoordinated::syncBoundsOrigin): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingRunLoop.cpp: (WebKit::CompositingRunLoop::isActive): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingRunLoop.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::LayerTreeHost): (WebKit::LayerTreeHost::~LayerTreeHost): (WebKit::LayerTreeHost::attachLayer): (WebKit::LayerTreeHost::detachLayer): (WebKit::LayerTreeHost::notifyCompositionRequired): (WebKit::LayerTreeHost::isCompositionRequiredOrOngoing const): (WebKit::LayerTreeHost::requestComposition): (WebKit::LayerTreeHost::requestUpdate): Deleted. * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.cpp: (WebKit::ThreadedCompositor::isActive const): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.h: Canonical link: https://commits.webkit.org/287835@main
webkit-commit-queue
force-pushed
the
coord-graphics-platform-layer-async-scrolling
branch
from
add827c to
d81c1b2
Compare
|
Committed 287835@main (d81c1b2): https://commits.webkit.org/287835@main Reviewed commits have been landed. Closing PR #37825 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
carlosgcampos
deleted the
coord-graphics-platform-layer-async-scrolling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d81c1b2
add827c