Convert coordinates properly for floats in writing-mode: sideways-lr #38450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-ews-buildbot
added
the
merging-blocked
fantasai
force-pushed
the
sideways-inline-floats
branch
from
d1fc0f7 to
259dbaf
Compare
fantasai
force-pushed
the
sideways-inline-floats
branch
from
259dbaf to
4f4ad94
Compare
|
EWS run on previous version of this PR (hash 4f4ad94) |
fantasai
force-pushed
the
sideways-inline-floats
branch
from
4f4ad94 to
21bf4db
Compare
|
EWS run on previous version of this PR (hash 21bf4db) |
alanbaradlay
approved these changes
Jan 2, 2025
fantasai
force-pushed
the
sideways-inline-floats
branch
from
21bf4db to
4eda029
Compare
|
EWS run on previous version of this PR (hash 4eda029) |
fantasai
force-pushed
the
sideways-inline-floats
branch
from
4eda029 to
5e39ba3
Compare
|
EWS run on current version of this PR (hash 5e39ba3) |
🧪 style
|
EWS run on current version of this PR (hash 5e39ba3) |
fantasai
added
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=285276 rdar://142227732 Reviewed by Alan Baradlay. Updates preparePlacedFloats to convert external floats to logical coordinates, and toMarginAndBorderBoxVisualRect to convert logical coordinates out to RenderBox coordinates in sideways-lr mode. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003.html: Added. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::toMarginAndBorderBoxVisualRect): (WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions): (WebCore::LayoutIntegration::LineLayout::preparePlacedFloats): Canonical link: https://commits.webkit.org/288382@main
webkit-commit-queue
force-pushed
the
sideways-inline-floats
branch
from
5e39ba3 to
7ec5fd9
Compare
|
Committed 288382@main (7ec5fd9): https://commits.webkit.org/288382@main Reviewed commits have been landed. Closing PR #38450 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7ec5fd9
5e39ba3
🛠 ios🛠 mac🛠 wpe🛠 win🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🛠 vision🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 playstation🛠 tv🛠 mac-safer-cpp🛠 tv-sim🛠 watch🛠 watch-sim