Skip to content

Conversation

@yulunwu2
Copy link
Contributor

@yulunwu2 yulunwu2 commented Jan 6, 2025

@yulunwu2 yulunwu2 self-assigned this Jan 6, 2025
@yulunwu2 yulunwu2 added the Layout and Rendering For bugs with layout and rendering of Web pages. label Jan 6, 2025
@yulunwu2 yulunwu2 marked this pull request as draft January 6, 2025 18:40
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 6, 2025
@yulunwu2 yulunwu2 removed the merging-blocked Applied to prevent a change from being merged label Jan 7, 2025
@yulunwu2 yulunwu2 changed the title [Cleanup] Refactor RenderTreeBuilderMultiColumn. [Cleanup] Refactor RenderTreeBuilderMultiColumn 2/2. Jan 7, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 7, 2025
@yulunwu2 yulunwu2 removed the merging-blocked Applied to prevent a change from being merged label Jan 7, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 7, 2025
@yulunwu2 yulunwu2 requested a review from alanbaradlay January 7, 2025 17:35
@alanbaradlay alanbaradlay added the merge-queue Applied to send a pull request to merge-queue label Jan 8, 2025
@yulunwu2 yulunwu2 marked this pull request as ready for review January 9, 2025 04:22
@yulunwu2 yulunwu2 removed the merging-blocked Applied to prevent a change from being merged label Jan 9, 2025
https://bugs.webkit.org/show_bug.cgi?id=285437
rdar://142420503

Reviewed by Alan Baradlay.

This change static variables and local/public/private
functions in the class so they are no longer intermingled.

Canonical link: https://commits.webkit.org/288871@main
@webkit-commit-queue
Copy link
Collaborator

Committed 288871@main (c27ba7a): https://commits.webkit.org/288871@main

Reviewed commits have been landed. Closing PR #38571 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c27ba7a into WebKit:main Jan 14, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 14, 2025
@alanbaradlay alanbaradlay added the merge-queue Applied to send a pull request to merge-queue label Jan 14, 2025
@nt1m nt1m removed the merge-queue Applied to send a pull request to merge-queue label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Layout and Rendering For bugs with layout and rendering of Web pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants