Skip to content

Conversation

@dcrousso
Copy link
Member

@dcrousso dcrousso commented Sep 1, 2022

365834e

Web Inspector: inline breakpoint widget should show auto-continue status
https://bugs.webkit.org/show_bug.cgi?id=244647

Reviewed by Patrick Angle.

* Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.js:
(WI.BreakpointInlineWidget.prototype._update):
(WI.BreakpointInlineWidget.prototype._addBreakpointEventListeners):
(WI.BreakpointInlineWidget.prototype._handleBreakpointAutoContinueChanged): Added.
(WI.BreakpointInlineWidget.prototype._handleBreakpointRemoved):
* Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.css:
(.inline-widget.breakpoint.auto-continue::after): Added.

Canonical link: https://commits.webkit.org/254057@main

03724e4

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style 🛠 ios 🛠 mac 🛠 wpe 🛠 🧪 win
✅ 🛠 ios-sim 🛠 mac-debug ❌ 🛠 gtk 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
❌ 🧪 api-ios 🧪 api-mac ❌ 🧪 api-gtk
🛠 tv 🧪 mac-wk1
🛠 tv-sim 🧪 mac-wk2
🛠 watch 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge 🛠 watch-sim 🧪 mac-wk2-stress

@dcrousso dcrousso self-assigned this Sep 1, 2022
@dcrousso dcrousso added Web Inspector Bugs related to the WebKit Web Inspector. WebKit Nightly Build labels Sep 1, 2022
@dcrousso dcrousso added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 1, 2022
https://bugs.webkit.org/show_bug.cgi?id=244647

Reviewed by Patrick Angle.

* Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.js:
(WI.BreakpointInlineWidget.prototype._update):
(WI.BreakpointInlineWidget.prototype._addBreakpointEventListeners):
(WI.BreakpointInlineWidget.prototype._handleBreakpointAutoContinueChanged): Added.
(WI.BreakpointInlineWidget.prototype._handleBreakpointRemoved):
* Source/WebInspectorUI/UserInterface/Views/BreakpointInlineWidget.css:
(.inline-widget.breakpoint.auto-continue::after): Added.

Canonical link: https://commits.webkit.org/254057@main
@webkit-commit-queue
Copy link
Collaborator

Committed 254057@main (365834e): https://commits.webkit.org/254057@main

Reviewed commits have been landed. Closing PR #3919 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 365834e into WebKit:main Sep 1, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 1, 2022
@dcrousso dcrousso deleted the eng/244647 branch September 1, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Inspector Bugs related to the WebKit Web Inspector.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants