-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in AudioSampleBufferConverter #39369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
jyavenard:eng/Reduce-use-of-WTF_ALLOW_UNSAFE_BUFFER_USAGE-in-AudioSampleBufferConverter
Jan 22, 2025
Merged
Reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in AudioSampleBufferConverter #39369
webkit-commit-queue
merged 1 commit into
WebKit:main
from
jyavenard:eng/Reduce-use-of-WTF_ALLOW_UNSAFE_BUFFER_USAGE-in-AudioSampleBufferConverter
Jan 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on current version of this PR (hash cf9723f) |
EWS run on previous version of this PR (hash cf9723f) |
cf9723f
to
691bf14
Compare
EWS run on previous version of this PR (hash 691bf14) |
youennf
approved these changes
Jan 22, 2025
691bf14
to
8e68cfd
Compare
EWS run on current version of this PR (hash 8e68cfd) |
…rter https://bugs.webkit.org/show_bug.cgi?id=286345 rdar://143378500 Reviewed by Youenn Fablet. Fly-By: Reset AudioBufferList's pointer indices within the loop to ensure proper pointer calculations should the packet contain more than 2048 frames. * Source/WebCore/platform/audio/cocoa/AudioSampleBufferConverter.mm: (WebCore::AudioSampleBufferConverter::processSampleBuffers): Canonical link: https://commits.webkit.org/289260@main
8e68cfd
to
4df5903
Compare
Committed 289260@main (4df5903): https://commits.webkit.org/289260@main Reviewed commits have been landed. Closing PR #39369 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4df5903
8e68cfd
🛠 playstation