Skip to content

Conversation

jyavenard
Copy link
Member

@jyavenard jyavenard commented Jan 22, 2025

4df5903

Reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in AudioSampleBufferConverter
https://bugs.webkit.org/show_bug.cgi?id=286345
rdar://143378500

Reviewed by Youenn Fablet.

Fly-By: Reset AudioBufferList's pointer indices within the loop to ensure
proper pointer calculations should the packet contain more than 2048 frames.

* Source/WebCore/platform/audio/cocoa/AudioSampleBufferConverter.mm:
(WebCore::AudioSampleBufferConverter::processSampleBuffers):

Canonical link: https://commits.webkit.org/289260@main

8e68cfd

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@jyavenard jyavenard self-assigned this Jan 22, 2025
@jyavenard jyavenard added the Media Bugs related to the HTML 5 Media elements. label Jan 22, 2025
@jyavenard jyavenard force-pushed the eng/Reduce-use-of-WTF_ALLOW_UNSAFE_BUFFER_USAGE-in-AudioSampleBufferConverter branch from cf9723f to 691bf14 Compare January 22, 2025 10:37
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for 691bf14. Live statuses available at the PR page, #39369

@jyavenard jyavenard requested a review from cdumez January 22, 2025 10:49
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 22, 2025
@jyavenard jyavenard removed the merging-blocked Applied to prevent a change from being merged label Jan 22, 2025
@jyavenard jyavenard force-pushed the eng/Reduce-use-of-WTF_ALLOW_UNSAFE_BUFFER_USAGE-in-AudioSampleBufferConverter branch from 691bf14 to 8e68cfd Compare January 22, 2025 12:50
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for 8e68cfd. Live statuses available at the PR page, #39369

@jyavenard jyavenard added the merge-queue Applied to send a pull request to merge-queue label Jan 22, 2025
…rter

https://bugs.webkit.org/show_bug.cgi?id=286345
rdar://143378500

Reviewed by Youenn Fablet.

Fly-By: Reset AudioBufferList's pointer indices within the loop to ensure
proper pointer calculations should the packet contain more than 2048 frames.

* Source/WebCore/platform/audio/cocoa/AudioSampleBufferConverter.mm:
(WebCore::AudioSampleBufferConverter::processSampleBuffers):

Canonical link: https://commits.webkit.org/289260@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Reduce-use-of-WTF_ALLOW_UNSAFE_BUFFER_USAGE-in-AudioSampleBufferConverter branch from 8e68cfd to 4df5903 Compare January 22, 2025 23:06
@webkit-commit-queue
Copy link
Collaborator

Committed 289260@main (4df5903): https://commits.webkit.org/289260@main

Reviewed commits have been landed. Closing PR #39369 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4df5903 into WebKit:main Jan 22, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants