-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Refactor HDR related macros to be more specific #39924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EWS run on previous version of this PR (hash bb5bcbe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But ContentsFormat
defines RGBA10
when ENABLE(PIXEL_FORMAT_RGB10)
is true. This switch statement has to handle RGBA10
anyway when ENABLE(PIXEL_FORMAT_RGB10)
is true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it would be a compile error if there ever were a combination of ENABLE(PIXEL_FORMAT_RGB10) but not ENABLE(DESTINATION_COLOR_SPACE_EXTENDED_SRGB), so if that ever comes up, someone will have to decide what behavior they want and implement it. For now, there is no reason to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes the platform parts of the code easier to follow. Thanks Sam!
bb5bcbe
to
543247e
Compare
EWS run on current version of this PR (hash 543247e) |
https://bugs.webkit.org/show_bug.cgi?id=286940 Reviewed by Said Abou-Hallawa. Replaces big HAVE(HDR_SUPPORT) and IOSurface specific macros with ENABLE pattern, isolating the choices to the platform enable code. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp: * Source/WebCore/html/ImageDataStorageFormat.h: * Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm: * Source/WebCore/page/PageOverlayController.cpp: * Source/WebCore/platform/graphics/ContentsFormat.cpp: * Source/WebCore/platform/graphics/ContentsFormat.h: * Source/WebCore/platform/graphics/DestinationColorSpace.cpp: * Source/WebCore/platform/graphics/DestinationColorSpace.h: * Source/WebCore/platform/graphics/Float16ArrayPixelBuffer.cpp: * Source/WebCore/platform/graphics/Float16ArrayPixelBuffer.h: * Source/WebCore/platform/graphics/GraphicsLayer.h: * Source/WebCore/platform/graphics/GraphicsLayerClient.h: * Source/WebCore/platform/graphics/ImageBufferPixelFormat.h: * Source/WebCore/platform/graphics/PixelBuffer.cpp: * Source/WebCore/platform/graphics/PixelBuffer.h: * Source/WebCore/platform/graphics/PixelBufferConversion.cpp: * Source/WebCore/platform/graphics/PixelFormat.cpp: * Source/WebCore/platform/graphics/PixelFormat.h: * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebCore/platform/graphics/ca/PlatformCALayer.mm: * Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h: * Source/WebCore/platform/graphics/ca/cocoa/ContentsFormatCocoa.h: * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: * Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp: * Source/WebCore/platform/graphics/cg/NativeImageCG.cpp: * Source/WebCore/platform/graphics/cocoa/IOSurface.h: * Source/WebCore/platform/graphics/cocoa/IOSurface.mm: * Source/WebCore/platform/ios/PlatformScreenIOS.mm: * Source/WebCore/platform/mac/PlatformScreenMac.mm: * Source/WebCore/rendering/RenderLayerBacking.cpp: * Source/WebCore/rendering/RenderLayerBacking.h: * Source/WebCore/rendering/RenderLayerCompositor.cpp: * Source/WebCore/rendering/RenderLayerCompositor.h: * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: Canonical link: https://commits.webkit.org/289827@main
543247e
to
742d687
Compare
Committed 289827@main (742d687): https://commits.webkit.org/289827@main Reviewed commits have been landed. Closing PR #39924 and removing active labels. |
742d687
543247e
🛠 win🧪 wpe-wk2🧪 win-tests🧪 api-wpe🧪 mac-wk1🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🧪 mac-intel-wk2🛠 playstation🛠 mac-safer-cpp🛠 tv-sim🛠 watch-sim