Skip to content

Address safer C++ static analysis warnings in PreconnectTask #40308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Address safer C++ static analysis warnings in PreconnectTask #40308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/WebKit/NetworkProcess/PreconnectTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class PreconnectTask final : public NetworkLoadClient {

void didFinish(const WebCore::ResourceError&, const WebCore::NetworkLoadMetrics&);

Ref<NetworkLoad> m_networkLoad;
const Ref<NetworkLoad> m_networkLoad;
CompletionHandler<void(const WebCore::ResourceError&, const WebCore::NetworkLoadMetrics&)> m_completionHandler;
Seconds m_timeout;
WebCore::Timer m_timeoutTimer;
Expand Down
1 change: 0 additions & 1 deletion Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ NetworkProcess/NetworkDataTask.cpp
NetworkProcess/NetworkDataTaskBlob.cpp
NetworkProcess/NetworkLoad.cpp
NetworkProcess/PingLoad.cpp
NetworkProcess/PreconnectTask.cpp
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementPersistentStore.cpp
Expand Down