Skip to content

Conversation

@lilyspiniolas
Copy link
Contributor

@lilyspiniolas lilyspiniolas commented Mar 4, 2025

dfb2558

[macOS] Add method for determining if accessibility setting "Differentiate without color" is enabled
https://bugs.webkit.org/show_bug.cgi?id=289029
rdar://146065406

Reviewed by Aditya Keerthi.

Add method `userPrefersDifferentiationWithoutColor` to `Theme` and
override it in `ThemeMac` to return the value of the accessibility
setting.

* Source/WebCore/platform/Theme.h:
(WebCore::Theme::userPrefersDifferentiationWithoutColor const):
* Source/WebCore/platform/mac/ThemeMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::userPrefersDifferentiationWithoutColor const):

Canonical link: https://commits.webkit.org/291545@main

845fff4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lilyspiniolas lilyspiniolas self-assigned this Mar 4, 2025
@lilyspiniolas lilyspiniolas added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 4, 2025
@lilyspiniolas lilyspiniolas added the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2025
…tiate without color" is enabled

https://bugs.webkit.org/show_bug.cgi?id=289029
rdar://146065406

Reviewed by Aditya Keerthi.

Add method `userPrefersDifferentiationWithoutColor` to `Theme` and
override it in `ThemeMac` to return the value of the accessibility
setting.

* Source/WebCore/platform/Theme.h:
(WebCore::Theme::userPrefersDifferentiationWithoutColor const):
* Source/WebCore/platform/mac/ThemeMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::userPrefersDifferentiationWithoutColor const):

Canonical link: https://commits.webkit.org/291545@main
@webkit-commit-queue
Copy link
Collaborator

Committed 291545@main (dfb2558): https://commits.webkit.org/291545@main

Reviewed commits have been landed. Closing PR #41826 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dfb2558 into WebKit:main Mar 4, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants