-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove UA styles for h1 in article, aside, nav, and section #45155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UA styles for h1 in article, aside, nav, and section #45155
Conversation
|
EWS run on previous version of this PR (hash cc14778) |
cc14778 to
df7e564
Compare
|
EWS run on previous version of this PR (hash df7e564) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reluctant to approve because I couldn't see any browser shipping this, nor did I see the spec/WPT PR being merged.
but after some research, I found Firefox is shipping it:
https://bugzilla.mozilla.org/show_bug.cgi?id=1964922
though I would like to see the spec PR being moved forward ideally.
|
Yeah, I'm also inclined to wait a little longer at this point. |
|
@annevk & @nt1m - I just synced WPT for this here - 295973@main |
df7e564 to
98d0c1e
Compare
|
EWS run on current version of this PR (hash 98d0c1e) |
|
Safe-Merge-Queue: Build #63856. |
https://bugs.webkit.org/show_bug.cgi?id=292765 rdar://151455566 Reviewed by Darin Adler. Firefox has shipped this. Chrome has also taken steps in deprecating this pattern and plans to follow Firefox. Upstream commit: web-platform-tests/wpt@ca3b40b Canonical link: https://commits.webkit.org/297671@main
98d0c1e to
2e84741
Compare
|
Committed 297671@main (2e84741): https://commits.webkit.org/297671@main Reviewed commits have been landed. Closing PR #45155 and removing active labels. |
2e84741
98d0c1e
🧪 win-tests