Skip to content

Conversation

@annevk
Copy link
Contributor

@annevk annevk commented May 9, 2025

@annevk annevk self-assigned this May 9, 2025
@annevk annevk added the CSS Cascading Style Sheets implementation label May 9, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 9, 2025
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label May 12, 2025
@annevk annevk force-pushed the eng/Remove-UA-styles-for-h1-in-article-aside-nav-and-section branch from cc14778 to df7e564 Compare May 12, 2025 07:43
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 12, 2025
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label May 12, 2025
@annevk annevk requested review from anttijk and nt1m May 12, 2025 08:56
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 12, 2025
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label May 13, 2025
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reluctant to approve because I couldn't see any browser shipping this, nor did I see the spec/WPT PR being merged.

but after some research, I found Firefox is shipping it:
https://bugzilla.mozilla.org/show_bug.cgi?id=1964922

though I would like to see the spec PR being moved forward ideally.

@annevk
Copy link
Contributor Author

annevk commented Jun 3, 2025

Yeah, I'm also inclined to wait a little longer at this point.

@Ahmad-S792
Copy link
Contributor

@annevk & @nt1m - I just synced WPT for this here - 295973@main

@annevk annevk force-pushed the eng/Remove-UA-styles-for-h1-in-article-aside-nav-and-section branch from df7e564 to 98d0c1e Compare July 21, 2025 06:40
@annevk annevk added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jul 21, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jul 21, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #63856.

https://bugs.webkit.org/show_bug.cgi?id=292765
rdar://151455566

Reviewed by Darin Adler.

Firefox has shipped this.

Chrome has also taken steps in deprecating this pattern and plans to
follow Firefox.

Upstream commit: web-platform-tests/wpt@ca3b40b

Canonical link: https://commits.webkit.org/297671@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-UA-styles-for-h1-in-article-aside-nav-and-section branch from 98d0c1e to 2e84741 Compare July 21, 2025 09:14
@webkit-commit-queue
Copy link
Collaborator

Committed 297671@main (2e84741): https://commits.webkit.org/297671@main

Reviewed commits have been landed. Closing PR #45155 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2e84741 into WebKit:main Jul 21, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 21, 2025
@annevk annevk deleted the eng/Remove-UA-styles-for-h1-in-article-aside-nav-and-section branch July 21, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants