[JSC] IPInt exception handlers should be tagged correctly #46821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash 3463cc0) |
kmiller68
approved these changes
Jun 16, 2025
|
|
||
| global _ipint_catch_entry | ||
| _ipint_catch_entry: | ||
| op(ipint_catch_entry, macro() |
There was a problem hiding this comment.
Doesn't this duplicate the code three times? Can we file a bug to make a macro entrypoint and use that instead?
There was a problem hiding this comment.
Yeah, filed. https://bugs.webkit.org/show_bug.cgi?id=294584
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=294580 rdar://149335739 Reviewed by Keith Miller. When JITCage is enabled, they must be JIT code. So, 1. When JIT is enabled, we just wrap these handlers with JIT code as the same way to the other trampolines as well. 2. When JIT is not enabled, then we just grab a code pointer to these ops. * Source/JavaScriptCore/assembler/JITOperationList.cpp: (JSC::llintOperations): * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/llint/InPlaceInterpreter.h: * Source/JavaScriptCore/llint/LLIntThunks.cpp: (JSC::LLInt::inPlaceInterpreterEntryThunk): Deleted. (JSC::LLInt::inPlaceInterpreterSIMDEntryThunk): Deleted. * Source/JavaScriptCore/llint/LLIntThunks.h: * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/wasm/WasmCallee.cpp: (JSC::Wasm::IPIntCallee::IPIntCallee): Canonical link: https://commits.webkit.org/296295@main
webkit-commit-queue
force-pushed
the
eng/JSC-IPInt-exception-handlers-should-be-tagged-correctly
branch
from
3463cc0 to
1f3b9d9
Compare
|
Committed 296295@main (1f3b9d9): https://commits.webkit.org/296295@main Reviewed commits have been landed. Closing PR #46821 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Constellation
deleted the
eng/JSC-IPInt-exception-handlers-should-be-tagged-correctly
branch
|
Looks like this caused a whole slew of undefined symbols on PlayStation (while EWS was downed by #46760): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1f3b9d9
3463cc0
🧪 ios-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🛠 playstation