Add initial implementation of the unprefixed fullscreen API #5045

cdumez · 2022-10-05T19:55:40Z

`6331c0f`

Add initial implementation of the unprefixed fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=246103

Reviewed by Tim Nguyen.

Add initial implementation of the unprefixed fullscreen API:
- https://fullscreen.spec.whatwg.org/#api

The feature is behind an experimental feature flag, off by default.

This is needed to unblock the WPT testing of the screen orientation API since
screen orientation locking requires being in fullscreen.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/capability-delegation/delegate-fullscreen-request-popup-same-origin.https.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/capability-delegation/delegate-fullscreen-request-subframe-same-origin.https.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-sandboxed-iframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt:
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/dom/Element+Fullscreen.idl:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::requestFullscreen):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/EventNames.h:
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::dispatchFullscreenChangeEvents):
* Source/WebCore/html/HTMLAttributeNames.in:

Canonical link: https://commits.webkit.org/255317@main

e5eb020

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-05T19:55:55Z

EWS run on previous version of this PR (hash d6439c9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~	❌ 🛠 jsc-armv7
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~	❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-05T23:22:04Z

EWS run on previous version of this PR (hash 516f9e2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

weinig · 2022-10-06T00:01:45Z

Source/WebCore/dom/Document+Fullscreen.idl

Give this is the standard one, I think you should swap things by putting this at the top of the interface, and annotating the non-standard ones as non-standard with the comments we usually add for such things.

Makes sense, will do.

weinig · 2022-10-06T00:02:38Z

Source/WebCore/dom/DocumentFullscreen.h

Is this really a win to be inline?

Will move to a new cpp file.

weinig · 2022-10-06T00:03:26Z

Source/WebCore/dom/DocumentOrShadowRoot.idl

This should be in its own file as a partial interface mixin

webkit-early-warning-system · 2022-10-06T01:52:28Z

EWS run on previous version of this PR (hash 5ccdaad)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	~~🛠 gtk~~	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	⏳ 🧪 api-mac	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-06T03:01:21Z

EWS run on previous version of this PR (hash ac24051)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-06T19:07:04Z

EWS run on previous version of this PR (hash 0ca47fc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	⏳ 🧪 api-mac	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-06T21:48:44Z

EWS run on previous version of this PR (hash c23ba45)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-06T21:56:21Z

Starting EWS tests for e3d2cd7. Live statuses available at the PR page, #5045

webkit-early-warning-system · 2022-10-06T21:56:21Z

EWS run on previous version of this PR (hash e3d2cd7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-10-07T02:00:30Z

EWS run on previous version of this PR (hash a60ee94)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 api-mac	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

cdumez · 2022-10-07T17:12:25Z

Looks generally fine to me, though I'd like less differences between the prefixed and unprefixed APIs, it seems to be mostly about preflight checks at the moment, which I think are reasonable to change in the old API as well.

I really do not want to change the behavior of the shipping API in this large patch. I think this carries risk and such large patches for feature A should not change the behavior of feature B.

nt1m · 2022-10-07T17:25:18Z

Looks generally fine to me, though I'd like less differences between the prefixed and unprefixed APIs, it seems to be mostly about preflight checks at the moment, which I think are reasonable to change in the old API as well.

I really do not want to change the behavior of the shipping API in this large patch. I think this carries risk and such large patches for feature A should not change the behavior of feature B.

@cdumez That's reasonable. Can we move all the new logic into FullscreenManager still and make webkitRequestFullscreen APIs wrap around requestFullscreen? (even if it means adding if/else checks).

I do plan to unify the code for both prefixed/unprefixed APIs anyway, so it would be easier if stuff wasn't scattered around.

cdumez · 2022-10-07T17:34:12Z

Looks generally fine to me, though I'd like less differences between the prefixed and unprefixed APIs, it seems to be mostly about preflight checks at the moment, which I think are reasonable to change in the old API as well.

I really do not want to change the behavior of the shipping API in this large patch. I think this carries risk and such large patches for feature A should not change the behavior of feature B.

@cdumez That's reasonable. Can we move all the new logic into FullscreenManager still and make webkitRequestFullscreen APIs wrap around requestFullscreen? (even if it means adding if/else checks).

Yes, I'll give this a shot.

webkit-early-warning-system · 2022-10-07T18:13:14Z

EWS run on previous version of this PR (hash 2ed5b29)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 🧪 win
	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	~~🧪 api-mac~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-10-07T19:09:39Z

EWS run on previous version of this PR (hash b3d2a3f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
~~🛠 🧪 merge~~	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

nt1m

LGTM, aside from my two comments (the unrelated header file change, and the regression in the test file).

webkit-early-warning-system · 2022-10-08T05:59:36Z

EWS run on current version of this PR (hash 7632d71)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	🛠 ios	🛠 mac	⏳ 🛠 wpe	🛠 🧪 win
	🛠 ios-sim	🛠 mac-debug	🛠 gtk	⏳ 🛠 wincairo
⏳ 🧪 webkitperl	🧪 ios-wk2	🛠 mac-AS-debug	🧪 gtk-wk2
	🧪 api-ios	🧪 api-mac	🧪 api-gtk
	🛠 tv	🧪 mac-wk1
🧪 services	🛠 tv-sim	🧪 mac-wk2
	🛠 watch	🧪 mac-AS-debug-wk2
	🛠 watch-sim	🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-08T05:59:37Z

EWS run on previous version of this PR (hash 7632d71)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 api-mac~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	~~🧪 mac-wk2-stress~~

webkit-early-warning-system · 2022-10-08T06:02:29Z

EWS run on current version of this PR (hash 3cc5edc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
	🛠 ios-sim	🛠 mac-debug	🛠 gtk	⏳ 🛠 wincairo
⏳ 🧪 webkitperl	🧪 ios-wk2	🛠 mac-AS-debug	🧪 gtk-wk2
	🧪 api-ios	⏳ 🧪 api-mac	🧪 api-gtk
	⏳ 🛠 tv	⏳ 🧪 mac-wk1
🧪 services	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2
	🛠 watch	🧪 mac-AS-debug-wk2
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-08T06:02:29Z

EWS run on previous version of this PR (hash 3cc5edc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	❌ 🛠 ios-sim	✅ 🛠 mac-debug	❌ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-10-08T17:34:20Z

EWS run on current version of this PR (hash e5eb020)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

https://bugs.webkit.org/show_bug.cgi?id=246103 Reviewed by Tim Nguyen. Add initial implementation of the unprefixed fullscreen API: - https://fullscreen.spec.whatwg.org/#api The feature is behind an experimental feature flag, off by default. This is needed to unblock the WPT testing of the screen orientation API since screen orientation locking requires being in fullscreen. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/capability-delegation/delegate-fullscreen-request-popup-same-origin.https.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/capability-delegation/delegate-fullscreen-request-subframe-same-origin.https.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/active-lock-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/event-before-promise-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-basic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-sandboxed-iframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/lock-unlock-check-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/onchange-event-subframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt: * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/dom/Element+Fullscreen.idl: * Source/WebCore/dom/Element.cpp: (WebCore::Element::requestFullscreen): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/EventNames.h: * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::dispatchFullscreenChangeEvents): * Source/WebCore/html/HTMLAttributeNames.in: Canonical link: https://commits.webkit.org/255317@main

webkit-commit-queue · 2022-10-08T22:37:32Z

Committed 255317@main (6331c0f): https://commits.webkit.org/255317@main

Reviewed commits have been landed. Closing PR #5045 and removing active labels.

cdumez self-assigned this Oct 5, 2022

cdumez added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Oct 5, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from d6439c9 to 516f9e2 Compare October 5, 2022 23:21

weinig reviewed Oct 6, 2022

View reviewed changes

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from 516f9e2 to 5ccdaad Compare October 6, 2022 01:52

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 6, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 6, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from 5ccdaad to ac24051 Compare October 6, 2022 03:00

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 6, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 6, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from ac24051 to 0ca47fc Compare October 6, 2022 19:06

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 6, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 6, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from 0ca47fc to c23ba45 Compare October 6, 2022 21:47

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from c23ba45 to e3d2cd7 Compare October 6, 2022 21:55

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 6, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 7, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from e3d2cd7 to a60ee94 Compare October 7, 2022 01:58

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from 8d97023 to 2ed5b29 Compare October 7, 2022 18:13

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 7, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 7, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from 2ed5b29 to b3d2a3f Compare October 7, 2022 19:09

nt1m approved these changes Oct 7, 2022

View reviewed changes

cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 7, 2022

webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Oct 7, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 8, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from b3d2a3f to 7632d71 Compare October 8, 2022 05:59

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from 7632d71 to 3cc5edc Compare October 8, 2022 06:02

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 8, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 8, 2022

cdumez force-pushed the 246103_unprefixed_fullscreen_api branch from 3cc5edc to e5eb020 Compare October 8, 2022 17:34

cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 8, 2022

webkit-early-warning-system force-pushed the 246103_unprefixed_fullscreen_api branch from e5eb020 to 6331c0f Compare October 8, 2022 22:37

webkit-early-warning-system merged commit 6331c0f into WebKit:main Oct 8, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 8, 2022

Add initial implementation of the unprefixed fullscreen API #5045

Add initial implementation of the unprefixed fullscreen API #5045

Uh oh!

Conversation

cdumez commented Oct 5, 2022 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

6331c0f

Uh oh!

webkit-early-warning-system commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weinig Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

cdumez Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

weinig Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

cdumez Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

weinig Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

cdumez Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 6, 2022

Uh oh!

webkit-early-warning-system commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez commented Oct 7, 2022

Uh oh!

nt1m commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez commented Oct 7, 2022

Uh oh!

webkit-early-warning-system commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nt1m left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Oct 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez commented Oct 5, 2022 •

edited by webkit-early-warning-system

Loading

`6331c0f`

webkit-early-warning-system commented Oct 5, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 5, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 6, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 6, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 6, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 6, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 6, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2022 •

edited

Loading

nt1m commented Oct 7, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2022 •

edited

Loading