Skip to content

Drop Custom toJS() / toJSNewlyCreated() functions for CSSTransformComponent #52047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

Drop Custom toJS() / toJSNewlyCreated() functions for CSSTransformComponent #52047

merged 1 commit into from
Oct 9, 2025
+0 −76

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Oct 9, 2025 •
edited by webkit-commit-queue
Loading

2b34978

Drop Custom toJS() / toJSNewlyCreated() functions for CSSTransformComponent
https://bugs.webkit.org/show_bug.cgi?id=300425

Reviewed by Darin Adler.

Drop Custom toJS() / toJSNewlyCreated() functions for CSSTransformComponent now
that the bindings generator knows how to generate them correctly.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp: Removed.
* Source/WebCore/css/typedom/transform/CSSTransformComponent.idl:

Canonical link: https://commits.webkit.org/301289@main

@cdumez cdumez self-assigned this Oct 9, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 9, 2025 •
edited
Loading

EWS run on current version of this PR (hash 2b5adee)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 💥 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
loading 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the CSS Cascading Style Sheets implementation label Oct 9, 2025
@cdumez cdumez marked this pull request as ready for review October 9, 2025 06:11
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 9, 2025
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 9, 2025
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 9, 2025
@cdumez
Drop Custom toJS() / toJSNewlyCreated() functions for CSSTransformCom…
2b34978 
…ponent

https://bugs.webkit.org/show_bug.cgi?id=300425

Reviewed by Darin Adler.

Drop Custom toJS() / toJSNewlyCreated() functions for CSSTransformComponent now
that the bindings generator knows how to generate them correctly.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp: Removed.
* Source/WebCore/css/typedom/transform/CSSTransformComponent.idl:

Canonical link: https://commits.webkit.org/301289@main
@webkit-commit-queue webkit-commit-queue force-pushed the 300425_CSSTransformComponent_no_CustomToJS branch from 2b5adee to 2b34978 Compare October 9, 2025 23:04
@webkit-commit-queue
Copy link
Collaborator

Committed 301289@main (2b34978): https://commits.webkit.org/301289@main

Reviewed commits have been landed. Closing PR #52047 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2b34978 into WebKit:main Oct 9, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darinadler darinadler darinadler approved these changes

@weinig weinig Awaiting requested review from weinig

@anttijk anttijk Awaiting requested review from anttijk

Assignees

@cdumez cdumez

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot