-
Notifications
You must be signed in to change notification settings - Fork 1.7k
REGRESSION(293871@main): WeChat app allocates large sizes of memory for high resolution images on iOS 26 #52489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
EWS run on previous version of this PR (hash 47439dd)
|
47439dd to
d8a7182
Compare
|
EWS run on current version of this PR (hash d8a7182) |
|
I wrote a test case for this PR but it requires adding a gigantic image. The size of this image is 11 MB. I am not sure whether it is okay to submit such a big file or not. I will address adding a layout test in a separate patch. |
…or high resolution images on iOS 26 https://bugs.webkit.org/show_bug.cgi?id=300903 rdar://162787553 Reviewed by Simon Fraser. 293871@main removes setting the value for the key kCGImageSourceSubsampleFactor in the decoding options. This option is useful when decoding a high resolution image which will be displayed on a much smaller rectangle. ImageIO decodes the image with a smaller rectangle in this case. This saves memory and CPU time. * Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::appendImageSourceOption): (WebCore::imageSourceMetadataOptions): (WebCore::imageSourceOptions): (WebCore::imageSourceThumbnailOptions): (WebCore::ImageDecoderCG::hasHDRGainMap const): (WebCore::ImageDecoderCG::frameDensityCorrectedSizeAtIndex const): (WebCore::ImageDecoderCG::fetchFrameMetaDataAtIndex const): (WebCore::createImageSourceMetadataOptions): Deleted. (WebCore::appendImageSourceOptions): Deleted. Canonical link: https://commits.webkit.org/301729@main
d8a7182 to
c4dc356
Compare
|
Committed 301729@main (c4dc356): https://commits.webkit.org/301729@main Reviewed commits have been landed. Closing PR #52489 and removing active labels. |
c4dc356
d8a7182