Skip to content

Conversation

@youennf
Copy link
Contributor

@youennf youennf commented Nov 21, 2025

d701988

MediaStreamTrackProcessor does not respect track.enabled = false
rdar://165199900
https://bugs.webkit.org/show_bug.cgi?id=302930

Reviewed by Jean-Yves Avenard.

Add a check to track.enabled before enqueuing video frames.

* LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor.worker.js:
(promise_test.async t):
* Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp:
(WebCore::MediaStreamTrackProcessor::tryEnqueueingVideoFrame):
* Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h:

Canonical link: https://commits.webkit.org/303389@main

012da2c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win loading 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
🧪 ios-wk2-wpt 🧪 api-mac-debug ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@youennf youennf self-assigned this Nov 21, 2025
@youennf youennf added the WebRTC For bugs in WebRTC label Nov 21, 2025
@youennf youennf requested a review from jyavenard November 21, 2025 11:18
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Nov 21, 2025
rdar://165199900
https://bugs.webkit.org/show_bug.cgi?id=302930

Reviewed by Jean-Yves Avenard.

Add a check to track.enabled before enqueuing video frames.

* LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor.worker.js:
(promise_test.async t):
* Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp:
(WebCore::MediaStreamTrackProcessor::tryEnqueueingVideoFrame):
* Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h:

Canonical link: https://commits.webkit.org/303389@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/MediaStreamTrackProcessor-does-not-respect-track-enabled-false branch from 012da2c to d701988 Compare November 21, 2025 13:25
@webkit-commit-queue
Copy link
Collaborator

Committed 303389@main (d701988): https://commits.webkit.org/303389@main

Reviewed commits have been landed. Closing PR #54307 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d701988 into WebKit:main Nov 21, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebRTC For bugs in WebRTC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants