Upstream some code for Private Click Measurement in NetworkDataTask #5455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whsieh
added
Platform
|
EWS run on previous version of this PR (hash 098306c) |
whsieh
requested review from
achristensen07,
hortont424,
johnwilander,
kcheney1 and
youennf
|
EWS run on previous version of this PR (hash 481f4f0)
|
|
EWS run on current version of this PR (hash 112fec9)
|
megangardner
approved these changes
Oct 17, 2022
|
Thanks for the review! |
https://bugs.webkit.org/show_bug.cgi?id=246642 rdar://101254515 Reviewed by Megan Gardner. Upstream some PCM code from WebKitAdditions for setting the `_needsNetworkTrackingPrevention` property on URL requests. * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::setPCMDataCarriedOnRequest): Note: we also replace `-_setIsKnownTracker:`, in the original upstreamed implementation, with a call to `-_setNeedsNetworkTrackingPrevention:`. The former was deprecated in favor of the latter in CFNetwork. (processPCMRequest): Deleted. Canonical link: https://commits.webkit.org/255656@main
webkit-early-warning-system
force-pushed
the
eng/246642
branch
from
112fec9 to
1ca8500
Compare
|
Committed 255656@main (1ca8500): https://commits.webkit.org/255656@main Reviewed commits have been landed. Closing PR #5455 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1ca8500
112fec9
🛠 🧪 win🧪 ios-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2