Skip to content

[macOS][WP] Add required methods to graphics filters #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
May 17, 2022
Merged

[macOS][WP] Add required methods to graphics filters #619

merged 0 commits into from
May 17, 2022

Conversation

@pvollan
Copy link
Contributor

@pvollan pvollan commented May 13, 2022 •
edited by webkit-early-warning-system
Loading

69306d3

[macOS][WP] Add required methods to graphics filters
https://bugs.webkit.org/show_bug.cgi?id=240398
<rdar://92460835 >

Reviewed by Geoffrey Garen.

Add required methods to graphics filters. These have been observed being used in telemetry.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/250665@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@pvollan pvollan self-assigned this May 13, 2022
@pvollan pvollan added WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). WebKit Nightly Build labels May 13, 2022
@pvollan pvollan requested a review from geoffreygaren May 13, 2022 21:11
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 14, 2022
@pvollan pvollan requested review from bnham and cdumez May 16, 2022 16:28
geoffreygaren
geoffreygaren approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label May 17, 2022
@pvollan
Copy link
Contributor Author

pvollan commented May 17, 2022

r=me

Thanks for reviewing!

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 17, 2022
@pvollan pvollan added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 17, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/macOSWP-Add-required-methods-to-graphics-filters branch from bb5f607 to 69306d3 Compare May 17, 2022 23:46
@webkit-early-warning-system webkit-early-warning-system merged commit 69306d3 into WebKit:main May 17, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 17, 2022

Committed r294362 (250665@main): https://commits.webkit.org/250665@main

Reviewed commits have been landed. Closing PR #619 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@bnham bnham Awaiting requested review from bnham

Assignees

@pvollan pvollan

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pvollan @webkit-early-warning-system @geoffreygaren