[ iOS EWS ] imported/w3c/web-platform-tests/dom/events/focus-event-document-move.html is a constant text failure

[JonWBedard]

b04f96f

[EWS] Accept GitHub hooks (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=235033


Reviewed by Aakash Jain

Trigger a subset of queues for incoming GitHub pull-requests.

* Tools/CISupport/ews-build/config.json: Enable webkitperl, webkitpy, services and style checks.
* Tools/CISupport/ews-build/loadConfig_unittest.py:
(ConfigDotJSONTest):
(ConfigDotJSONTest.test_multiple_scheduers_for_builder):
* Tools/CISupport/ews-build/master.cfg: Accept GitHub hooks, specify variables
to extract from incoming request.
* Tools/CISupport/ews-build/steps.py:
(GitHub):
(GitHub.repository_urls): Concatenate all valid projects with the base URL.
(GitHub.pr_url): Given a repository and pull-request number, return the URL
for that pull-request.
(ConfigureBuild.add_pr_details):
(GitHubMixin): Deleted.


Canonical link: https://commits.webkit.org/245978@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[JonWBedard]

Not ready for landing yet, wanted to post this code for reference.

[aj062]

how is this scheduler triggered?

[JonWBedard]

GitHub hooks generate by pull-requests have this:
-H "X-GitHub-Event: pull_request
in their header. My understanding is that upon receiving this hook, buildbot triggers the scheduler named pull request

[aj062]

Overall looks good. few minor comments.
Also one unit-test is failing, need to delete/update it https://ews-build.webkit.org/#/builders/20/builds/65384

[aj062]

still unclear who is setting this 'repository' property. Can we just skip it altogether?

[JonWBedard]

'repository' comes from the GitHub hook, Making it optional may be reasonable, but we don't want to drop it entirely. This is one of the arguments that will change for security pull-requests.

[aj062]

can we do this:
def pr_url(cls, pr_number, repository_url=None):

[aj062]

This if condition seems incorrect, please use explicit parenthesis to make it correct and clear.

[aj062]

I preferred previous one-liner, but this is ok as well.

[aj062]

r=me (with above comments)

[JonWBedard]

Landed https://commits.webkit.org/245978@main (b04f96f)!