[WebGPU] Work around https://bugs.webkit.org/show_bug.cgi?id=240219 #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
added
Bindings
https://bugs.webkit.org/show_bug.cgi?id=240441 https://bugs.webkit.org/show_bug.cgi?id=240219 is about a bug where we can't say "optional thingy = 0" in an IDL file. This patch works around that in WebGPU by replacing it with "optional thingy" and then "thingy.value_or(0)" in the C++ code. This is temporary, until https://bugs.webkit.org/show_bug.cgi?id=240219 is fixed. No new tests because there is no behavior change. * Modules/WebGPU/GPUBuffer.cpp: (WebCore::GPUBuffer::mapAsync): (WebCore::GPUBuffer::getMappedRange): * Modules/WebGPU/GPUBuffer.h: * Modules/WebGPU/GPUBuffer.idl:
Contributor
Author
|
@cdumez already reviewed this in https://bugs.webkit.org/show_bug.cgi?id=240441. Landing now. |
litherum
force-pushed
the
eng/WebGPU-Work-around-httpsbugs-webkit-orgshow_bug-cgiid240219
branch
from
76dfb76 to
c111a1e
Compare
Contributor
Author
|
This landed in https://trac.webkit.org/changeset/294373/webkit somehow. I have no idea how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c111a1e