Implement fullscreen rendering update step #7435

nt1m · 2022-12-10T10:16:07Z

`cba51d1`

Implement fullscreen rendering update step
https://bugs.webkit.org/show_bug.cgi?id=249069
rdar://103209495

Reviewed by Alex Christensen.

Event dispatching should be done by the rendering update steps.

https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering
https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-ready-allowed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-namespaces-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-iframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-inactive-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-pseudo-class-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-scroll-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-size-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/ua-style-iframe-expected.txt:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-and-move-to-iframe-expected.txt: Added.
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-timing-expected.txt: Removed.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):
(WebCore::FullscreenManager::resolvePendingPromise):
(WebCore::FullscreenManager::rejectPendingPromise):
(WebCore::FullscreenManager::dispatchPendingEvents):
(WebCore::FullscreenManager::notifyAboutFullscreenChangeOrError): Deleted.
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::updateRendering):
* Source/WebCore/page/Quirks.cpp:
(WebCore::handleBBCQuirks):
(WebCore::Quirks::shouldDelayFullscreenEventWhenExitingPictureInPictureQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/QuirksData.h:

Canonical link: https://commits.webkit.org/289984@main

1d8a74a

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2022-12-10T10:19:49Z

EWS run on previous version of this PR (hash d6730dc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	💥 🧪 gtk-wk2
	~~🧪 api-ios~~	❌ 🧪 mac-wk1	⏳ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2022-12-10T10:19:50Z

EWS run on previous version of this PR (hash 28b8ed9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	~~🧪 mac-wk1~~	⏳ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk2~~
⏳ 🧪 services	✅ 🛠 tv-sim	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2022-12-10T18:25:31Z

EWS run on previous version of this PR (hash c301761)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	💥 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	⏳ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-01-19T01:35:29Z

EWS run on previous version of this PR (hash 7b3409b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	❌ 🧪 api-gtk
⏳ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-01-19T04:16:55Z

EWS run on previous version of this PR (hash db880e4)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	⏳ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	⏳ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	⏳ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	⏳ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-07-21T02:30:20Z

EWS run on previous version of this PR (hash ea2bbf6)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	❌ 🧪 api-mac	❌ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	❌ 🧪 mac-wk2	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-07-21T02:39:59Z

EWS run on previous version of this PR (hash bde2076)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-07-21T02:46:38Z

EWS run on previous version of this PR (hash 3ae9f7d)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~
	~~🛠 tv~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-07-21T02:53:03Z

EWS run on previous version of this PR (hash bb5e826)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	❌ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-01-31T22:09:59Z

EWS run on previous version of this PR (hash 0f6a6d3)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	✅ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2025-01-31T23:33:04Z

EWS run on previous version of this PR (hash eb0da5a)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-06T17:12:05Z

EWS run on previous version of this PR (hash 020fbba)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/dom/FullscreenManager.cpp

Source/WebCore/dom/FullscreenManager.h

webkit-early-warning-system · 2025-02-06T18:41:36Z

EWS run on previous version of this PR (hash 4a9642b)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	❌ 🛠 playstation
	❌ 🛠 tv	~~🛠 mac-safer-cpp~~
	❌ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-06T23:23:23Z

EWS run on previous version of this PR (hash 2d35039)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-02-07T00:43:26Z

EWS run on current version of this PR (hash 1d8a74a)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=249069 rdar://103209495 Reviewed by Alex Christensen. Event dispatching should be done by the rendering update steps. https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-ready-allowed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-namespaces-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-iframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/model/move-to-inactive-document-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-pseudo-class-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-scroll-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-root-block-size-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/ua-style-iframe-expected.txt: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-and-move-to-iframe-expected.txt: Added. * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-timing-expected.txt: Removed. * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::requestFullscreenForElement): (WebCore::FullscreenManager::willEnterFullscreen): (WebCore::FullscreenManager::didExitFullscreen): (WebCore::FullscreenManager::resolvePendingPromise): (WebCore::FullscreenManager::rejectPendingPromise): (WebCore::FullscreenManager::dispatchPendingEvents): (WebCore::FullscreenManager::notifyAboutFullscreenChangeOrError): Deleted. * Source/WebCore/dom/FullscreenManager.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::updateRendering): * Source/WebCore/page/Quirks.cpp: (WebCore::handleBBCQuirks): (WebCore::Quirks::shouldDelayFullscreenEventWhenExitingPictureInPictureQuirk const): Deleted. * Source/WebCore/page/Quirks.h: * Source/WebCore/page/QuirksData.h: Canonical link: https://commits.webkit.org/289984@main

webkit-commit-queue · 2025-02-07T04:43:25Z

Committed 289984@main (cba51d1): https://commits.webkit.org/289984@main

Reviewed commits have been landed. Closing PR #7435 and removing active labels.

nt1m requested review from cdumez and rniwa as code owners December 10, 2022 10:16

nt1m self-assigned this Dec 10, 2022

nt1m added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Dec 10, 2022

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 28b8ed9 to d6730dc Compare December 10, 2022 10:18

nt1m marked this pull request as draft December 10, 2022 10:22

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 10, 2022

nt1m removed the merging-blocked Applied to prevent a change from being merged label Dec 10, 2022

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from d6730dc to c301761 Compare December 10, 2022 18:25

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 10, 2022

nt1m removed the merging-blocked Applied to prevent a change from being merged label Jan 19, 2023

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from c301761 to 7b3409b Compare January 19, 2023 01:30

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 19, 2023

nt1m removed the merging-blocked Applied to prevent a change from being merged label Jan 19, 2023

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 7b3409b to db880e4 Compare January 19, 2023 04:15

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 19, 2023

nt1m removed the merging-blocked Applied to prevent a change from being merged label Jul 21, 2024

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from db880e4 to ea2bbf6 Compare July 21, 2024 02:30

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from ea2bbf6 to bde2076 Compare July 21, 2024 02:39

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from bde2076 to 3ae9f7d Compare July 21, 2024 02:46

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 3ae9f7d to bb5e826 Compare July 21, 2024 02:52

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 8315d7b to 0f6a6d3 Compare January 31, 2025 22:09

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 0f6a6d3 to eb0da5a Compare January 31, 2025 23:32

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 1, 2025

nt1m removed the merging-blocked Applied to prevent a change from being merged label Feb 6, 2025

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from eb0da5a to 020fbba Compare February 6, 2025 17:11

jernoble reviewed Feb 6, 2025

View reviewed changes

Source/WebCore/dom/FullscreenManager.cpp Outdated Show resolved Hide resolved

Source/WebCore/dom/FullscreenManager.cpp Outdated Show resolved Hide resolved

Source/WebCore/dom/FullscreenManager.h Outdated Show resolved Hide resolved

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 020fbba to 4a9642b Compare February 6, 2025 18:41

nt1m requested a review from jernoble February 6, 2025 18:47

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 6, 2025

nt1m removed the merging-blocked Applied to prevent a change from being merged label Feb 6, 2025

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 4a9642b to 2d35039 Compare February 6, 2025 23:23

achristensen07 approved these changes Feb 6, 2025

View reviewed changes

nt1m force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 2d35039 to 1d8a74a Compare February 7, 2025 00:43

nt1m added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 7, 2025

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 7, 2025

nt1m added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 7, 2025

webkit-commit-queue force-pushed the eng/Implement-fullscreen-rendering-update-step branch from 1d8a74a to cba51d1 Compare February 7, 2025 04:43

webkit-commit-queue merged commit cba51d1 into WebKit:main Feb 7, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 7, 2025

nt1m deleted the eng/Implement-fullscreen-rendering-update-step branch February 7, 2025 05:26

Implement fullscreen rendering update step #7435

Implement fullscreen rendering update step #7435

Uh oh!

Conversation

nt1m commented Dec 10, 2022 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cba51d1

Uh oh!

webkit-early-warning-system commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Feb 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nt1m commented Dec 10, 2022 •

edited by webkit-early-warning-system

Loading

`cba51d1`

webkit-early-warning-system commented Dec 10, 2022 •

edited

Loading

webkit-early-warning-system commented Dec 10, 2022 •

edited

Loading

webkit-early-warning-system commented Dec 10, 2022 •

edited

Loading

webkit-early-warning-system commented Jan 19, 2023 •

edited

Loading

webkit-early-warning-system commented Jan 19, 2023 •

edited

Loading

webkit-early-warning-system commented Jul 21, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 21, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 21, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 21, 2024 •

edited

Loading

webkit-early-warning-system commented Jan 31, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 31, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 6, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 6, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 6, 2025 •

edited

Loading

webkit-early-warning-system commented Feb 7, 2025 •

edited

Loading