Skip to content

Conversation

@nt1m
Copy link
Member

@nt1m nt1m commented Jan 8, 2023

c9fdb2c

Remove unused DeprecatedGlobalSettings.h includes
https://bugs.webkit.org/show_bug.cgi?id=250287
rdar://103996597

Reviewed by Tim Horton.

These have been unused for a while.

* Source/WebCore/css/CSSStyleDeclaration.cpp:
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
* Source/WebCore/loader/ServerTimingParser.cpp:
* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:
* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
* Source/WebCore/platform/ios/PlatformScreenIOS.mm:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
* Source/WebCore/rendering/RenderListBox.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
* Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:

Canonical link: https://commits.webkit.org/258629@main

97e736e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 gtk-wk2
🧪 api-ios ✅ 🧪 mac-wk1 🧪 api-gtk
✅ 🛠 tv 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
loading 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@nt1m nt1m requested a review from cdumez as a code owner January 8, 2023 04:17
@nt1m nt1m self-assigned this Jan 8, 2023
@nt1m nt1m added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 8, 2023
@nt1m nt1m added the request-merge-queue Request a pull request to be added to merge-queue once ready label Jan 8, 2023
@nt1m nt1m added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Jan 8, 2023
https://bugs.webkit.org/show_bug.cgi?id=250287
rdar://103996597

Reviewed by Tim Horton.

These have been unused for a while.

* Source/WebCore/css/CSSStyleDeclaration.cpp:
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
* Source/WebCore/loader/ServerTimingParser.cpp:
* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:
* Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
* Source/WebCore/platform/ios/PlatformScreenIOS.mm:
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
* Source/WebCore/rendering/RenderListBox.cpp:
* Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
* Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:

Canonical link: https://commits.webkit.org/258629@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Remove-unused-DeprecatedGlobalSettings-h-includes branch from 97e736e to c9fdb2c Compare January 8, 2023 05:22
@webkit-early-warning-system webkit-early-warning-system merged commit c9fdb2c into WebKit:main Jan 8, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 258629@main (c9fdb2c): https://commits.webkit.org/258629@main

Reviewed commits have been landed. Closing PR #8365 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 8, 2023
@nt1m nt1m deleted the eng/Remove-unused-DeprecatedGlobalSettings-h-includes branch January 8, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants