Skip to content

Nullptr crash in effectiveAssignedNodes #8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

Nullptr crash in effectiveAssignedNodes #8437

merged 1 commit into from
Jan 10, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Jan 10, 2023 •
edited by webkit-early-warning-system
Loading

bb2cc18

Nullptr crash in effectiveAssignedNodes
https://bugs.webkit.org/show_bug.cgi?id=250365

Reviewed by Alexey Shvayka and Tim Nguyen.

Add a nullptr check in effectiveAssignedNodes.

* LayoutTests/fast/shadow-dom/manual-slot-gc-crash-expected.txt: Added.
* LayoutTests/fast/shadow-dom/manual-slot-gc-crash.html: Added.
* Source/WebCore/dom/SlotAssignment.cpp:
(WebCore::effectiveAssignedNodes):

Canonical link: https://commits.webkit.org/258708@main

044d0de

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@rniwa rniwa requested a review from cdumez as a code owner January 10, 2023 08:18
@rniwa rniwa self-assigned this Jan 10, 2023
@rniwa rniwa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Jan 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 10, 2023 •
edited
Loading

EWS run on current version of this PR (hash 044d0de)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 10, 2023
@rniwa
Nullptr crash in effectiveAssignedNodes
bb2cc18 
https://bugs.webkit.org/show_bug.cgi?id=250365

Reviewed by Alexey Shvayka and Tim Nguyen.

Add a nullptr check in effectiveAssignedNodes.

* LayoutTests/fast/shadow-dom/manual-slot-gc-crash-expected.txt: Added.
* LayoutTests/fast/shadow-dom/manual-slot-gc-crash.html: Added.
* Source/WebCore/dom/SlotAssignment.cpp:
(WebCore::effectiveAssignedNodes):

Canonical link: https://commits.webkit.org/258708@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258708@main (bb2cc18): https://commits.webkit.org/258708@main

Reviewed commits have been landed. Closing PR #8437 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit bb2cc18 into WebKit:main Jan 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 10, 2023
@rniwa rniwa deleted the fix250365 branch January 10, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nt1m nt1m nt1m approved these changes

@shvaikalesh shvaikalesh shvaikalesh approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@rniwa rniwa

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rniwa @webkit-early-warning-system @webkit-commit-queue @nt1m @shvaikalesh