[WebGPU] Simplify the lifetime of GPUPresentationContext within GPUCanvasContextCocoa #9284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
force-pushed
the
eng/WebGPU-Simplify-the-lifetime-of-GPUPresentationContext-within-GPUCanvasContextCocoa
branch
2 times, most recently
from
e8b2a93 to
4b1cabe
Compare
|
EWS run on previous version of this PR (hash 825ba07)
|
|
EWS run on previous version of this PR (hash e8b2a93)
|
|
EWS run on current version of this PR (hash 4b1cabe)
|
webkit-ews-buildbot
added
the
merging-blocked
djg
reviewed
Jan 30, 2023
Comment on lines
+123
to
+124
There was a problem hiding this comment.
when requesting to configure and there is no configuration, is that an error?
There was a problem hiding this comment.
Yes, though I'm going to end up rewriting this function entirely (as in #8963) so I didn't want to spend a lot of time polishing up the existing code in this function.
tadeuzagallo
approved these changes
Jan 30, 2023
litherum
added
merge-queue
…nvasContextCocoa https://bugs.webkit.org/show_bug.cgi?id=251067 rdar://104784569 Reviewed by Tadeu Zagallo. There's no reason to lazily create the GPUPresentationContext; we can just create it eagerly, which allows us to use a Ref instead of a RefPtr for the object, thereby eliminating one potential state in the class. * Source/WebCore/html/canvas/GPUCanvasContextCocoa.cpp: (WebCore::presentationContextDescriptor): (WebCore::GPUCanvasContextCocoa::GPUCanvasContextCocoa): (WebCore::GPUCanvasContextCocoa::reshape): (WebCore::GPUCanvasContextCocoa::unconfigurePresentationContextIfNeeded): (WebCore::GPUCanvasContextCocoa::configurePresentationContextIfNeeded): (WebCore::GPUCanvasContextCocoa::getCurrentTexture): (WebCore::GPUCanvasContextCocoa::createPresentationContextIfNeeded): Deleted. * Source/WebCore/html/canvas/GPUCanvasContextCocoa.h: Canonical link: https://commits.webkit.org/259564@main
|
Committed 259564@main (2f40848): https://commits.webkit.org/259564@main Reviewed commits have been landed. Closing PR #9284 and removing active labels. |
webkit-early-warning-system
force-pushed
the
eng/WebGPU-Simplify-the-lifetime-of-GPUPresentationContext-within-GPUCanvasContextCocoa
branch
from
4b1cabe to
2f40848
Compare
webkit-commit-queue
removed
the
merge-queue
litherum
deleted the
eng/WebGPU-Simplify-the-lifetime-of-GPUPresentationContext-within-GPUCanvasContextCocoa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2f40848
4b1cabe