Skip to content

[GitHub] git-webkit pr doesn't sort Xcode project files before uploading #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
May 24, 2022
Merged

[GitHub] git-webkit pr doesn't sort Xcode project files before uploading #948

merged 0 commits into from
May 24, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented May 23, 2022 •
edited by webkit-early-warning-system
Loading

24f50e7

[GitHub] git-webkit pr doesn't sort Xcode project files before uploading
https://bugs.webkit.org/show_bug.cgi?id=239975
<rdar://92976140 >

Reviewed by Chris Dumez.

* Tools/Scripts/hooks/pre-commit: Sort Xcode project files on commit.

Canonical link: https://commits.webkit.org/250916@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this May 23, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels May 23, 2022
@JonWBedard JonWBedard requested a review from cdumez May 23, 2022 22:21
cdumez
cdumez approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@JonWBedard JonWBedard added the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GitHub-git-webkit-pr-doesnt-sort-Xcode-project-files-before-uploading branch from 7d7954e to 24f50e7 Compare May 24, 2022 15:39
@webkit-early-warning-system webkit-early-warning-system merged commit 24f50e7 into WebKit:main May 24, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294748 (250916@main): https://commits.webkit.org/250916@main

Reviewed commits have been landed. Closing PR #948 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@JonWBedard JonWBedard deleted the eng/GitHub-git-webkit-pr-doesnt-sort-Xcode-project-files-before-uploading branch June 14, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@JonWBedard JonWBedard

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JonWBedard @webkit-early-warning-system @cdumez