[Fix] App freezes during Navigation If we inspect using RWI #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sends the message to RWI which results in the busy loop blocking webkit main thread.Because it takes a while to read and transmit the message.
Author
|
when app sends large message to their backend, network inspect agent sends the message to RWI which results in the busy loop blocking webkit main thread. Because it takes a while to read and transmit the message. |
magomez
approved these changes
Sep 26, 2024
|
@magomez @kkanag314 : this really helps performance with RWI, thanks for the patch! |
|
@blino , @kkanag314 : I will try to upstream this change. |
|
@blino , @kkanag314 : upstream PR: WebKit/WebKit#39064 |
webkit-commit-queue
pushed a commit
to pgorszkowski-igalia/WebKit
that referenced
this pull request
Jan 16, 2025
https://bugs.webkit.org/show_bug.cgi?id=285978 Reviewed by Adrian Perez de Castro. In case of large message, we can speed its reading up by increase the reading buffer to expected size of the message (which is read from the header of the message). The solution was proposed in WebPlatformForEmbedded/WPEWebKit#1407. Original author: Krishna Priya K (https://github.com/kkanag314). * Source/WTF/wtf/glib/SocketConnection.cpp: (WTF::SocketConnection::readMessage): Canonical link: https://commits.webkit.org/289009@main
aperezdc
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Mar 13, 2025
…gi?id=285978 [GTK][WPE] Remote Inspector: speed up of reading large message https://bugs.webkit.org/show_bug.cgi?id=285978 Reviewed by Adrian Perez de Castro. In case of large message, we can speed its reading up by increase the reading buffer to expected size of the message (which is read from the header of the message). The solution was proposed in WebPlatformForEmbedded/WPEWebKit#1407. Original author: Krishna Priya K (https://github.com/kkanag314). * Source/WTF/wtf/glib/SocketConnection.cpp: (WTF::SocketConnection::readMessage): Canonical link: https://commits.webkit.org/289009@main Canonical link: https://commits.webkit.org/282416.480@webkitglib/2.46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] App freezes during Navigation If we inspect using RWI