CPack instructions added; tests made optional #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpoisel
force-pushed
the
cpackage
branch
2 times, most recently
from
de3a457 to
ba15da0
Compare
paroga
force-pushed
the
master
branch
2 times, most recently
from
114b89e to
0aae3d1
Compare
|
Thanks for the PR. I cherry-picked most of your changes and pushed them to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added instructions for building CPack packages from this CMake configuration. Furthermore, I also made the compilation of unit-tests optional.
The problem I have with CMake's ExternalProject-module is that it does not play well with cross-compilation (a.k.a. CMake toolchain files). Therefore I added two new definitions (
LIBWEBSOCKETS_INCLUDE_DIRSandLIBWEBSOCKETS_LIBRARIES) that allow for overriding the results offind_package(LibWebSockets).This is just a proposal, so feel free to make any counterproposals. :-)