Skip to content

Conversation

@rpoisel
Copy link
Contributor

@rpoisel rpoisel commented Nov 14, 2016

Executing include_directories() with CHECK_INCLUDE_DIRS being set to NOTFOUND leads to an error. Therefore, an additional condition has been introduced.

@rpoisel
Copy link
Contributor Author

rpoisel commented Nov 14, 2016

Furthermore, I'd like to encourage you to prefer using target_include_directories() over include_directories() - see https://cmake.org/cmake/help/v3.0/manual/cmake-buildsystem.7.html#transitive-usage-requirements for details. Or here: https://rix0r.nl/blog/2015/08/13/cmake-guide/

@paroga
Copy link
Member

paroga commented Nov 14, 2016

Added via bca88b1.
Ad target_include_directories(): I made the change already local, but it requires at least CMake 2.8.11 but Ubuntu 12.04 ships with 2.8.7. :-(

@paroga paroga closed this Nov 14, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.565% when pulling 3b016f8 on rpoisel:check into 6f071e6 on WebProcessControl:master.

@rpoisel
Copy link
Contributor Author

rpoisel commented Nov 14, 2016

Would it be possible to merge this pull request? It does not use target_include_directories() and I cannot cross compile your library due to unsatisfied dependencies now. :-(

@paroga
Copy link
Member

paroga commented Nov 14, 2016

Did you see commit bca88b1, which is in master already?

@rpoisel
Copy link
Contributor Author

rpoisel commented Nov 14, 2016

Now I saw it. Sorry and thx! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants