Skip to content

Conversation

@rpoisel
Copy link
Contributor

@rpoisel rpoisel commented Nov 14, 2016

In my case CMAKE_PROJECT_NAME is also set in a parent directory and thus overrides the value of variable being used here. My proposal is to set your project name like this.

@paroga
Copy link
Member

paroga commented Nov 14, 2016

Is there then a problem with CPACK_PACKAGE_FILE_NAME too, which can be overwritten from outside? Or is just not a problem in your project? Setting CPACK_GENERATOR from outside shouldn't be a problem...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.565% when pulling c60f810 on rpoisel:package-project-name into bca88b1 on WebProcessControl:master.

@paroga
Copy link
Member

paroga commented Nov 14, 2016

How do you build the project ATM? Who sets CMAKE_PROJECT_NAME? If something is able to override this variable, isn't there a problem for all other variables too?

@rpoisel
Copy link
Contributor Author

rpoisel commented Nov 14, 2016

Yes, you are right. Setting CPACK_PACKAGE_FILE_NAME from outside is sufficient. Forget this pull-request. :-)

@rpoisel rpoisel closed this Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants