-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Handling of text documents does not comply with modern HTML spec #4143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of text documents does not comply with modern HTML spec #4143
Conversation
|
EWS run on previous version of this PR (hash 90a576f) |
|
It will be interesting to see if this change triggers any test failures in our own test cases. Waiting on EWS... |
90a576f to
d10634a
Compare
|
EWS run on previous version of this PR (hash d10634a)
|
d10634a to
68cde4c
Compare
cdumez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://bugs.webkit.org/show_bug.cgi?id=244950 <rdar://problem/99719728> Reviewed by Chris Dumez. The spec language in https://html.spec.whatwg.org/multipage/browsing-the-web.html#read-text, indicates that Text documents must be in no-quirks mode: (7.11.4.3 Set document's mode to "no-quirks".) This is in conflict with the source code in the TextDocument constructor: setCompatibilityMode(DocumentCompatibilityMode::QuirksMode); This causes the following WPT failure: wpt /html/browsers/browsing-the-web/read-text/load-text-plain.html * LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-text/load-text-plain-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_putall.tentative.any-expected.txt * LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_putall.tentative.any.worker-expected.txt * LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt * LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt * LayoutTests/platform/glib/fast/loader/text-document-wrapping-expected.txt * LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.https.worker-expected.txt * LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any-expected.txt * LayoutTests/platform/glib/imported/w3c/web-platform-tests/wasm/jsapi/global/value-set.any.worker-expected.txt * LayoutTests/platform/gtk/fast/forms/targeted-frame-submission-expected.txt * LayoutTests/platform/ios-wk2/fast/forms/targeted-frame-submission-expected.txt * LayoutTests/platform/ios-wk2/fast/loader/text-document-wrapping-expected.txt * LayoutTests/platform/ios/fast/forms/targeted-frame-submission-expected.txt * LayoutTests/platform/ios/fast/loader/text-document-wrapping-expected.txt * LayoutTests/platform/mac/fast/forms/targeted-frame-submission-expected.txt * LayoutTests/platform/mac/fast/loader/text-document-wrapping-expected.txt * LayoutTests/platform/mac/http/tests/misc/acid3-expected.txt * LayoutTests/platform/win/fast/loader/text-document-wrapping-expected.txt * LayoutTests/platform/wincairo/fast/loader/text-document-wrapping-expected.txt * Source/WebCore/html/TextDocument.cpp: Canonical link: https://commits.webkit.org/254389@main
68cde4c to
e30caa2
Compare
|
Committed 254389@main (e30caa2): https://commits.webkit.org/254389@main Reviewed commits have been landed. Closing PR #4143 and removing active labels. |
e30caa2
68cde4c
🛠 🧪 win